Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions don't seem to work #3

Open
yatesco opened this issue Jun 8, 2022 · 1 comment
Open

instructions don't seem to work #3

yatesco opened this issue Jun 8, 2022 · 1 comment

Comments

@yatesco
Copy link

yatesco commented Jun 8, 2022

Hi there - the main README states:

let queries = Loader::get_queries_from("examples/postgre.sql").unwrap().queries;

However, it appears that the get_queries_from (

pub fn get_queries_from(content: &str) -> Result<Loader> {
):

  • expects the actual SQL not a path
  • has no field called queries

The following works:

let queries = Loader::read_queries_from("examples/postgre.sql").unwrap();

Have I misunderstood something? If not, do you want a PR?

@manute
Copy link
Owner

manute commented Jun 13, 2022

Hey @yatesco ,
it was changed recently in this PR but not the documentation. You can see the code here which accepts a content str and doesn't have the field queries, you can see an example here.

I'd be very happy to review a PR!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants