Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12 deprecation warnings #22

Open
ddbrown30 opened this issue Jul 5, 2024 · 4 comments
Open

v12 deprecation warnings #22

ddbrown30 opened this issue Jul 5, 2024 · 4 comments

Comments

@ddbrown30
Copy link

canvas.grid.isHex is deprecated. Use of canvas.grid.isHexagonal instead.
BaseGrid#w is deprecated in favor of BaseGrid#sizeX.
BaseGrid#h is deprecated in favor of BaseGrid#sizeY.

Screenshot 2024-07-05 130537
Screenshot 2024-07-05 130521
Screenshot 2024-07-05 130528

@ottyn
Copy link

ottyn commented Aug 3, 2024

+1 on this for FVTT 12 support

@manuelVo
Copy link
Owner

manuelVo commented Aug 3, 2024

The indicated warnings should not cause any issues. Those are only a warning that things need to be changed for foundry 14 compatibility. Are there any noticeable issues with routinglib?

@ottyn
Copy link

ottyn commented Aug 3, 2024

The indicated warnings should not cause any issues. Those are only a warning that things need to be changed for foundry 14 compatibility. Are there any noticeable issues with routinglib?

While the warnings themselves don't cause any issues, the constant console spam every time a token is moved can get quite annoying. A short 30 minute combat testing session in my test world generated 500+ warning messages in the console just from the Witch character with her familiar token riding on her and from the Summoner/Eidolon characters set to follow. Both are done using the Ridable module which uses Routinglib.

I haven't seen any issues arise where the module is not working so far though.

@IHaveThatPower
Copy link

IHaveThatPower commented Oct 20, 2024

Submitted a pull request that I think covers (most of) these: #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants