-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other web player #35
Comments
youtube.com? |
@homamgamer This extension uses the song name and artist to search for lyrics. It is foreseeable that YouTube’s lyrics match rate will be low In other words, this extension is only suitable for music players |
you can still figure out a way around it, you just have to work harder |
for example, you have this addon that can look for lyrics for youtube videos |
Hi @mantou132 , |
@MFRehan It seems to be easy to support, but only Deezer Premium can play a full-length track |
@MFRehan v1.5 should support Deezer, but currently I only test it under a free account. And will remove the native lyrics feature |
@mantou132 Great, Thank you for the great effort! |
Support https://listen.tidal.com/ please. |
@lostfilm It seems that Tidal is a very suitable webapp. But it cannot be used in my area, so I cannot log in to debug. |
@mantou132 As a tidal user, I will be happy if I can help you test it. 😉 |
also it would be perfect for apple music web |
@Louissenny v1.5.10 support TIDAL, But I don’t have a complete test, there may be a bug. |
@dimivell Apple music is a very good service, but their web client is really bad, I will consider it again in the future |
@mantou132 thanks a lot! I will check it out later and tell you if there's any bugs. Once again thank you for your work! |
@mantou132 thank you for the consideration i think it would satisfy a lot of apple products owners who have windows laptops and can't listen to apple music (itunes has been discontinued and it lags a lot) |
@mantou132 Hey, I've been using it for couple hours, here are some feedbacks: For TIDAL: It works on both Chrome and Edge, fails to work on Chrome Dev due to unknown reasons (Maybe Chrome Dev has some limitations). And there's a bug: every time when a song is ended and the next song kicks in, the lyrics stuck on the end of the last song and becomes irresponsive, even if I click other songs it stays the same. This happens on both PIP and page mode, only gets back to normal if I refresh the webapp. It won't happen if I manually skip a song or select a song everytime. For YouTube Music: As long as the extension is on the webpage goes dark, happens on Chrome, Chrome Dev and Edge, as you can see from the picture below. After I switched the extension off it gets back to normal. I've tried with different network conditions and it's all the same. I guess YouTube has some sort of detecting methods. Again I want to shout out to your wonderful work in such a short amount of time 👍 your extension really is the best of its kind (at least for TIDAL users, lol) thank you so much |
@Louissenny Thank you for the test. I can’t log in to TIDAL and YouTube Music right now, so these issues cannot be fixed yet. |
@mantou132 No problem. Please take your time ; ) |
@Louissenny I just released v1.5.12 and v1.5.13, trying to fix the bugs of YouTube music and tidal respectively |
@mantou132 thanks for the work, seems like you stayed up late last night. As for YouTube Music, it works now but face a similar problem with TIDAL, when the song automatically switches to next one the lyrics becomes unsynchronized with the song or stops showing. It won't happen when I manually select or switch the song. I guess this is due to either songs on YTM has different duration (esp. for those with a music video) or YTM has a weird setting: it won't wait until a song is fully ended and switches early. P.S.: If you want I can give you my TIDAL and YTM accounts for you to debug, feel free to ask me, it's not a big deal ; ) |
@dimivell I tried to add lyrics to apple music, but apple music has strict restrictions and cannot access the lyrics server. I haven't found a way to break through the restrictions. |
@mantou132 i understand thank you very much for trying i hope they make it easier at some point |
hey @mantou132 there is this webplayer that is alternative to apple music web player.. https://musi.sh/ could the extension work for this website? it has its own lyrics but i prefer your extension |
@skeletclique v1.5.14 support apple music. |
@mantou132 works great although pause and play buttons dont work as sometimes lyrics and cover don't load too |
@mantou132 support https://nhaccuatui.com and https://beta.nhaccuatui.com please |
If there are other excellent Web Players(PWA), the extension can also be adapted.
Joox// Also need a suitable name, e.g: lyrics widget
Ways to support other players:
content_scripts
currentPlatform
andlocalConfig
The text was updated successfully, but these errors were encountered: