Add FSE correction on each spectra before focusing all spectra #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added step for subtracting fitted FSE from each spectra before focusing The idea behind this change is that subtracting FSE is more physically correct and symmetrasion of the profile should be no longer necessary.
Fixes errors reported by system tests
5 tasks
|
Opened a newer PR at #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this change is that subtracting FSE is more physically correct and symmetrasion of the profile should be no longer necessary or deprecated.
Description of work:
During the fitting of NCP to each spectra, store the FSE corrections on workspaces.
During the data processing part before focusing data for y sapce fit, use the stored fse on the workspaces and subtract only the fse for the first mass from the isolated first mass for all spectra (before doing the weighted average).
It's not necessary to subtract the FSE for the other masses because this is done already when we subtract the ncp fits (since strictly speaknig the ncp fits include the FSE corrections i.e. NCP+FSE)
To test:
Part of the work in #113