Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in interactive documentation page #284

Open
turbcool opened this issue Sep 4, 2020 · 1 comment · May be fixed by #339
Open

Mistake in interactive documentation page #284

turbcool opened this issue Sep 4, 2020 · 1 comment · May be fixed by #339

Comments

@turbcool
Copy link

turbcool commented Sep 4, 2020

There is a mistake in code on the interactive documentation page.

application.inject(injectionTarget, 'notifications', 'notification-messages:service')

'notification-messages:service' should be 'service:notifications'

@jacobq
Copy link
Contributor

jacobq commented May 26, 2022

Ha, just saw this (after mentioning in #311), but you are right. In fact, now in Ember 4.x injecting like that no longer works, so I've suggested removing this part of the docs in #339

@jacobq jacobq linked a pull request May 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants