Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git subtree for pymie #43

Open
vnmanoharan opened this issue Sep 4, 2017 · 1 comment
Open

Use git subtree for pymie #43

vnmanoharan opened this issue Sep 4, 2017 · 1 comment

Comments

@vnmanoharan
Copy link
Contributor

We should separate out the Mie scattering code into its own python package, and then include it as a git submodule in the structural-color repository. The new Mie package might be useful for other calculations besides those in structcol.

@vnmanoharan
Copy link
Contributor Author

Code is now separated in mie-separated branch. Currently using structcol requires installing the python-mie package.

In the future, we might want to consider using git subtree to include the pymie code into the structcol repository, while maintaining the history. Above I recommended git submodule, but it's not easy to get that to work with python packages containing a root directory with a setup.py file, since the extra directory makes it difficult to import the package. git subtree would allow us to directly incorporate only the module subdirectory (python-mie/pymie) into the structcol directory. Here are a couple of posts about using git subtree with subdirectories:

https://jrsmith3.github.io/merging-a-subdirectory-from-another-repo-via-git-subtree.html

https://stackoverflow.com/questions/23937436/add-subdirectory-of-remote-repo-with-git-subtree

And one on git subtree vs git submodule: http://candidtim.github.io/git/2013/10/20/git-subtree.html

@vnmanoharan vnmanoharan changed the title Mie code should be separated from structural color package Use git subtree for pymie Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant