Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example data files missing in conda distributions #342

Open
barkls opened this issue May 14, 2020 · 3 comments
Open

example data files missing in conda distributions #342

barkls opened this issue May 14, 2020 · 3 comments

Comments

@barkls
Copy link
Contributor

barkls commented May 14, 2020

I don't know how widespread this is, but sometimes the conda distribution doesn't properly bring the example data files along for the ride, which means users can't go through the tutorials. It would be nice to get some examples of systems on which this has happened.

@barkls
Copy link
Contributor Author

barkls commented May 18, 2020

This problem arises because the exampledata folder has no __init__.py so conda doesn't pick it up. This means maybe our exampledata has never worked from a conda distribution? I don't think that's the case so maybe something has changed about what conda/conda-forge includes by default. Here are a few solutions:

  1. Add a __init__.py file to hp/core/tests/example_data. I don't really like this solution since there are no python files there and you shouldn't be able to import this as a submodule.

  2. Adjust our conda recipe on conda-forge to explicitly include all files in the exampledata directory in the package. I think this is the better option.

@briandleahy
Copy link
Contributor

If you're looking for input, I agree with you -- this seems to be a conda-specific problem, so a conda-specific solution is probably best (i.e. your number 2 above). We can always come back to this if it ends up being a more general problem.

@barkls barkls self-assigned this May 21, 2020
@barkls barkls mentioned this issue Jun 16, 2020
@barkls barkls removed their assignment Feb 25, 2021
@mdhoney
Copy link

mdhoney commented Feb 2, 2022

It would be nice to get some examples of systems on which this has happened.

This happened for me. HoloPy installed fine with conda, but the whole tree below tests was missing. I ended up manually grabbing the files as a ZIP. What kind of information would be helpful to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants