-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion and Testing #11
Comments
Added more device. |
The test version is working for me. I ran the reset and install scripts. Successfully enabled and disabled Maximum Lifespan Mode and Full Capacity Mode without issue. (Fedora 37, Acer Swift X SFX14-51G) |
Confirm working on Dell |
test_version10 works fine. |
Thank you for testing. @anzigo @monethass @mascherm |
Just curious about the charging icon in the system tray/indicator , when charger is plugged. Currently in my laptop, when the actual battery level reaches the end-threshold/limit, my system tray/indicator icon shows charger is unplugged and running on battery. I was just wondering if it shows unplugged/on-battery for everyone. Difficult to explain, so explaining with examples case1 and 2 below. CASE1 CASE2 In case 2 does your system tray/indicator icon shows as plugged or unplugged? |
i get the same results as you, in case 1 it shows charging and in case 2 it shows not charging. i have a question, what exactly is the use case for the start charging treshold? |
start charging threshold is threshold level when the device start charging after charging was stop using end threshold.. Better with an example.
Example 2. You set Start-Threshold 50% and End-threshold to 60%.
A common assumption is that start-threshold is used to force discharge the battery 50%, but it is not. Start-threshold is a level at which the charger connects to the battery and starts charging, just like end threshold is a level at which the charger is disconnected from the battery. I have a asus viwobook laptop, and in my laptop there is no option to set start-threshold. Most laptops manufacturer recommends or set start-threshold 2-10% below endthreshold |
thanks for the explaination! |
Hello @mascherm @monethass @anzigo Changes:
Currently when charger is powered and plugged-in, if the threshold is active and battery reaches threshold limit, the battery indicator icon switches to on-battery/charger-unplugged. That why i introduced this option.
|
Just tried on Dell, and both feature worked as expected. However, a feedback on the indicator icon, is that if it's enabled, it can't be distinguished between the two state of "charging" or "holding". For example, I set my threshold to 60/80. Now I see my battery is at 70%, and having the charging icon, but I do not know if it's at the cycle of charging from 60% to 80%, or it already has been charged to 80%, and currently it's discharging from 80% to 60% because my laptop is using more power than the power brick can supply. A suggestion is that to use this extension's icon to distinguish between those two states instead of changing the original battery icon. |
Like the idea. Initially i thought of using extensions icon to display the charging status instead of the system icon. But no space on the icon (it is a very small icon) and I ran out of ideas if how to modify the icon to provide more information about charging and holding (unless I add another icon which I dont want to). One way of implementing was to change to color the icon, but it look bad and inconsistent as rest of the system icons are symbolic. |
could you please add more gnome version support? |
Gnome 43 and 44 are supported. Which Gnome version are you using? |
@ViBE-HU I had a look to support gnome 42 and the changes are massive. I don't think can support any gnome versions earlier than 43. |
@maniacx good to know. bad news for compatibility cause bunch of major distros still on 42x. |
Ok Not confirming, but I may give it a go when I have free time for gnome 42. |
that would be cool. translation is much more easier if i can test the extension. |
Can you please give me the exact gnome version used on pop os? I can see that latest release of gnome42 is 42.9. Is pop-os using 42.9 or an older version of 42? |
i did not mention pop os. at the moment i use ubuntu 20.04 and 22.04 machines. 22.04 has gnome 42.5 |
@maniacx no worries. i did not forget the project. but im a bit busy now and need a little time to test a few machines. i also want to test a dual battery machine to translate properly the related strings. so the dell with ubuntu 22.04 is tested. you was right. i had to install and i have a question. i explain it first cause i'm not a developer. i'm a dual boot user and i have windows too on most machines. on windows you can use Dell Power Manager to manage battery/charging. this program controls U/EFI(?) directly. but as i understand your plugin does not and it stores the configuration locally. so if i change it on linux it will won't affect permanently. am i right? if yes, is it possible to control the same way as windows does? |
When you set the threshold using this extension, the only think the extension does is executes 1 or both commands below depending upon the mode. Also on every reboot to linux it will enable the previous settings
Rest everything is done by libsmbiosutils (using smbios-battery-ctl) which I think interacts with the UEFI bios (I may be wrong). I didnt read much into it as I do not have dell laptop, and my only goal was to set battery threshold. From what I have read, now Dell has two ways of changing charging threshold.
|
i mean i tested it already and the plugin does not interact with the UEFI(?). in Dell UEFI you can set power management. it will affects permanently until you change it again in UEFI or on OS (Windows in this case) level. on Windows Dell Power Manager is the same tool. so if you set the charging mod via UEFI or windows it will be permanent. Linux will also read UEFI power management settings IF nothing else overwrite it. of course your plugin can overwrite locally on OS level. of course it is not bad. it just not the same. in general your plugin is clearly the best solution at the moment for average laptop users. i encourage you to enhance it if you can. yes, you can do anything in Dell UEFI what you can do with your plugin. the only difference that Dell UEFI offers much more rules. for example you can set different threshold rules for each days. meanwhile i tested Lenovo too. sadly you're right. it does not recognise the host natively. but is there any dependencies for Lenovo machines? cause i tried to test it with the command but nothing happened. the host OS is 20.04. and if i set conservation mode via Lenovo Vantage On Windows 10 Ubuntu will follow the rule. |
@ViBE-HU |
No. there are no dependencies required for Lenovo, it is natively supported by the kernel but it should be installed and running on lenovo hardare and not on Virtual Machine/Virtual Box. |
now i see. you are right. but something still wrong. i did a more detailed test on my E5450. i tried first the mode menu and Express Mode is the only one which really interacts with my machine's UEFI. the method i used:
only Express Mode worked. any other mode does not have permanent effect. then i tried to configure @maniacx i also noticed that if i set
|
To actually monitor if user have change the mode t using command line, I will have to continuously run |
@ViBE-HU Did you ever try changing threshold using cctk in Ubuntu? Are you familar with it? But My extension doesnt support it. So was thinking about including it. EDIT: |
and no way to switch on/of this forcing and simply just read UEFI on boot? also i'm not familiar how system menu works but isn't it possible to check the actual config when the user open the exact submenu? gnome also checks somehow charging time when and bunch of plugins have sliders. are those different? btw as i mentioned i'm not a developer. i'm a kinda advanced user with a light clue about programming. so i don't do random things and if you think cctk can improve the plugin and it's functionality then i can take a try. just need a clear guide what exactly should i check. of course i don't wanna kill my machine but at the moment i'm using it for testing cases and i can take a look. |
To implement this feature.
But as per your test libsmbios on reports only "express" and "standard" correctly on reboot.
Sorry, I dont want to implement.
Not sure, But I think in regards to batthery threshold there is no benefits. On some laptops libsmbios doesnt work, but cctk works so I thinking of adding support. I actually installed dell command configure (cctk) on Ubuntu 20.04 om my asus just to try. but it said something like libcrypto missing. For me it is not big deal because ubuntu 20.04 is use for testing only, and if any problem I will just format it and reinstall. |
i would like to test the extension on my ThinkPad R61. it is from ~2008. not sure is it supported. the extension starts with unexpected error. |
Wow its way old. Not all thinkpad have this feature. it will work if kernel supports it. you can check if any of the following files exist. |
yeah it's pretty old but one of my favourite machine for home office. i thought the ThinkPad legacy rules are also support this machine. it has only one removable battery. here's the only working output: |
Seem like it has it. can you give me the output in this specific order |
sadly only the firs command gives detailed output.
others just reply with "no device" message or something like that however the files are present in BAT0. |
Unfortunately if these commands dont work, then too extension wont work |
@maniacx i think i found something. as i mentioned i'm not a programmer but i checked the scripts maybe i can figure out what's going on and your ThinkPad legacy script contains a maybe your script is not complete or something different? i tested this machine with Ubuntu 22.04 and i guess most oddware IBM/Lenovo ThinkPad (starting with T4x/R4x/X4x series) might work with this method. |
So how are you setting threshold now? Can you run this again and give me the output.
|
the first two has output. but the last two say that no device
i did exactly what the commenter said:
then these example values for testing:
and then restarted the laptop and voilà. it's working. |
As this extension support several device it search for files at certain path do know what type of laptop it is installed on.
If these 2 files exist, it will know it is legacy thinkpad tp-smp
Strange You laptop has all 5 files. Just out of curiosity does this files still exist in your system after installing tp-smp-dkms and restarting. or do they get removed? You can check again with
|
|
@ViBE-HU , @monethass Currently in the extension , it only checks if smbios-battery-ctl is present and report device as dell devices. Now since knowing that other brand laptops may also install this program, I will have to add additional checks for detecting if the laptop is a dell laptop or not. On your dell laptop, please and comfirm if this file exist on your device. According to the kernel code, all dell device register this file/folder
|
Yes the folder exists |
just checked:
btw i have no time to test at the moment but looks like settings are still not permanent on dell somehow. is this a bug or it's normal? |
Not permanent? I will also check on my end too. |
now finally my E5470 is back and i tested the plugin again. if i change the mode it does not permanent. i thought your recent update targeted this thing. it's working but it is only permanent if i change the mode via Windows. on Ubuntu it is temporary. is this normal? |
I am not understanding what do mean by permanent. I am assuming you talking about charging threshold from windows and ubuntu. When you boot from windows to Ubuntu it should restore your charging threshold values what was ubuntu. This is an example of behavior
This an example of normal behavior of the extension. Is it behaving differently for you? |
I understand this issue to be for general discussions too, so I am posting it here instead of a new issue. I am using this extension on my Lenovo ThinkPad L13 Yoga and are happy with it. In addition to the charge thresholds, my device supports changes to the charge behavior:
I am using these currently from the console, and would love to see support for that via gnome, just like the charge thresholds. I think it would be best to have it in the same extension, or do you think that should be a separate one? My use case: Alternative use case: |
Lets continue our discussion here #67 (comment) |
Thanks for this beautiful extension ::)) |
Creating this issue for discussion about this extension and testing newer version before uploading on gnome extension website.
So that tester, can share your result and your opinion here.
Feel free to provide any suggestion, or any discussion related here.
The zip will contain two scripts
This will also set device-type to 0 so that the extension re-checks the sysfs path your device uses.
This will remove/reset-to-default all preferences so you will lose all your settings and custom threshold after running reset.sh
Recommended to run ./reset.sh before ./install.sh to test the extension and renable extension from extensions/extension manager.
But if you dont want to reset and lose your settings and only install and test the version, thats fine too
The text was updated successfully, but these errors were encountered: