chore: update to ng 18 #1421
chore: update to ng 18 #1421
Conversation
There was a problem hiding this comment.
I took a shot at upgrading the Angular dependencies of this project to help keep things updated. I tried to keep things as minimal as possible to keep review simple. If this seems promising and you'd like additional changes please just let me know and I'll try to help.
| "@angular/platform-browser": "^17.0.7", | ||
| "@angular/platform-browser-dynamic": "^17.0.7", | ||
| "@angular/router": "^17.0.7", | ||
| "@angular/animations": "^18.0.7", |
There was a problem hiding this comment.
Ran this command to install all required dependencies in the upgrade:
npx ng update @angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular/[email protected] \
@angular-devkit/[email protected] \
@angular-eslint/[email protected] \
@types/node@^18.19.1 \
@typescript-eslint/eslint-plugin@7 \
eslint@8
| "outputPath": "dist/quickstart-demo", | ||
| "outputPath": { | ||
| "base": "dist/quickstart-demo", | ||
| "browser": "" |
There was a problem hiding this comment.
Adding "browser": "" to a few places was one of the few manual additions I had to make not covered by the Angular migrations. See this issue for details.
oaklandcorp-jkaiser
force-pushed
the
chore/angular-18
branch
from
28f3aba
to
000af3d
Compare
oaklandcorp-jkaiser
force-pushed
the
chore/angular-18
branch
from
000af3d
to
1db94d4
Compare
|
LGTM 👍 |
|
Hi @VPecquerie @oaklandcorp-jkaiser, Thank you for your time and efforts. I am looking forward to hearing from you! |
|
@sarahwvb: I'm still awaiting feedback from the project maintainer @manfredsteyer. I tried to change as few things as possible and to follow the approach used in the last version to reduce the effort required to review and merge but ultimately it is their decision if these make the cut. |
|
Hi @manfredsteyer, When have you planned to update your project to be compatible with Angular 18? We are blocked by it, and we cannot upgrade our project, because this library doesn't support it. We tried running the library using this branch, but it doesn't have a dist folder, and therefore, it doesn't build and cannot be recognized in our project. Is there any expectations to solve this issue soon? Ps: If someone has some suggestion for an alternative libraries that support Authentication like this one, please, bright us up. :) |
|
We are also blocked by this pending change! |
|
We are also waiting for this update; there seems to be an incompatibility at the moment with version 18, and we would like to test with this update. thanks |
There's this other library that officially supports Angular 18. |
|
@webmatth @NikolaKrstic94 @claudia9 The library is compatible with Angular 18. So, the library is compatible with every Angular 14+ project. |
|
@davidsarkany: That is my understanding as well. During my own internal testing the last major NPM release 17 still works for an Angular 18 site. I would suggest that if anyone needs to upgrade to Angular 18 ASAP to try testing things with the last NPM release of this project. You might be surprised and find things working. Clearly there is a benefit in keeping maintenance up on this project so that is why I'm interested in seeing these changes pushed through (and hopefully future releases that more closely track Angular releases...) even if I don't strictly need them today. |
We've tried with the current release, but there seems to be a problem with how angular 18 manages redirections. I'm not quite sure why, but there's a redirect loop while reading the URL from the query params. |
|
@webmatth So Angular 17 works same config and Angular 18 got infinite redirect loop? It's looks strange, I use Angular 18 + keycloak + code flow combo with this lib every day. |
Alright, I was hoping this update would resolve my issue, but it seems it might be unrelated. I'll look into it further. Thanks |
|
We are using this project for quite a while (Since ng7 IIRC), and it works really well and brings a lot of features in a well-designed manner. But it has always lagged quite a bit behind with regards to keeping up with Angular development. To be fair, this repo has become tremendously popular, currently having 230+ open issues and 45 open PRs - which means it is causing quite some noise for the original contributor. 😅 This can lead to quick-wins (like this one) going unnoticed for longer periods. Last time (Upgrade to ng16 in !1357) it was thanks to @L-X-T informing @manfredsteyer personally, that the PR was finally merged few days later. So maybe we can pull that stunt again? 🙈😇 |
|
Yes, @sambernet, we're currently a bit underwarter since we do not only have to modernize the community packages but also a lot of other stuff (like for example all our workshop slides and labs) and also write and talk about it. I now that it's frustrating that it takes us so long to update our packages to support the latest Angular release. And already Version 19 is around the corner. I'm gonna talk to @manfredsteyer in person this evening on howto improve this process. |
|
Small update @sambernet: I proposed to @manfredsteyer to give me write access to this repository, so we can speed up the process here. He agreed and put it on his todo list. So we're working on a solution :-) |
|
Another quick update, I'm now officially collaborator :-) |
Nice! I'm sure the users of this project will appreciate your support! |
|
Any news regarding the merge of this change and finally support of Angular 18? |
|
Yeah, I'm still working on it, will be updated soon.
I'm very sorry for the delay!
|
|
or angular 19? ;-) |
|
Of course, @z0mt3c, the updates will include NG 18 & NG 19. Hope i'll be able to finish this Sunday. |
Upgraded Angular dependencies to version 18.
Closes #1413