Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update angular versions to master builds #11

Closed
manekinekko opened this issue Oct 16, 2018 · 5 comments
Closed

refactor: update angular versions to master builds #11

manekinekko opened this issue Oct 16, 2018 · 5 comments
Labels
flag: wontfix This will not be worked on good first issue Good for newcomers Hacktoberfest type: feature New feature or request

Comments

@manekinekko
Copy link
Owner

We should use angular#master^HEAD
See this PR as a reference: xlayers/xlayers#50
@manekinekko manekinekko added type: feature New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 16, 2018
@manekinekko manekinekko mentioned this issue Oct 16, 2018
Open
@tinesoft
Copy link

Ok, i'm on it!

@tinesoft
Copy link

Ok, quick update on this issue:
Versions have been updated(see tinesoft@8e86d10), but there are currently 2 issues when ng building or ng serving the app:
image

@tinesoft tinesoft mentioned this issue Oct 18, 2018
Merged
@manekinekko
Copy link
Owner Author

thanks for the updates.

@thanhpd
Copy link

thanhpd commented Oct 24, 2018

May I ask why should we switch to master builds? There's no guarantee that the latest version will work without error, which is the reason official stable releases exist.

@manekinekko manekinekko added the flag: wontfix This will not be worked on label Dec 17, 2018
@manekinekko
Copy link
Owner Author

Closing this feature request.
Reason: Angular master builds may introduce some incompatibilities with 3rd party libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: wontfix This will not be worked on good first issue Good for newcomers Hacktoberfest type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manekinekko @tinesoft @thanhpd