Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel 5 have no class name htmlBuilder or FormBuilder #10

Open
ghost opened this issue Jun 4, 2015 · 7 comments
Open

laravel 5 have no class name htmlBuilder or FormBuilder #10

ghost opened this issue Jun 4, 2015 · 7 comments

Comments

@ghost
Copy link

ghost commented Jun 4, 2015

in laravel 5 the form and html components extracted to LaravelCollective package . you need to use it as dependancy and make the formBuilder class extends it FormBuilder .

@manavo
Copy link
Owner

manavo commented Jun 4, 2015

To keep supporting Laravel 4 though it can't be added as a dependency.

The docs should be updated though to mention it!

@ghost
Copy link
Author

ghost commented Jun 6, 2015

then add new branch and tag for laravel 5 development (maybe I can help)

@dlnsk
Copy link

dlnsk commented Feb 12, 2016

+1
It doesn't work in 5.2

@manavo
Copy link
Owner

manavo commented Feb 12, 2016

@dlnsk if you include the LaravelCollective package, does it work?

@dlnsk
Copy link

dlnsk commented Feb 12, 2016

No.
Even if I correct errors with extents, change bindShared() to singleton() it rises an error:

ErrorException in FormBuilder.php line 35: Argument 3 passed to Collective\Html\FormBuilder::__construct() must implement interface Illuminate\Contracts\View\Factory, string given, called in /vendor/manavo/laravel-bootstrap-forms/src/Manavo/BootstrapForms/BootstrapFormsServiceProvider.php on line 38 and defined (View: /resources/views/claim/edit.blade.php)

@dlnsk
Copy link

dlnsk commented Feb 12, 2016

Catch it!

Should change to
$form = new FormBuilder($app['html'], $app['url'], $app['view']);
in BootstrapFormsServiceProvider.php

Now there isn't errors, but label of group passed througth htmlentities so displays as code.

@dlnsk
Copy link

dlnsk commented Feb 12, 2016

I've placed output of openGroup and closeGroup into $this->toHtmlString() and now it works fine.
But this package doesn't support .form-horizontal style of form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants