Fix KeyError with missing Host in HTTP::Request #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbuenemann
changed the title
|
Marking WIP, because I think simply returning |
|
Btw. spec failures are unrelated and fixed in #23. |
When calling `HTTP::Client#exec` with an `HTTP::Request` instance the Host header is not automatically filled by the http client, so we need to add it manually or the `host_matches?` check in the stub will fail with a `KeyError` exception.
felixbuenemann
force-pushed
the
fix-crash-with-missing-host-header
branch
from
4655868 to
00574dd
Compare
felixbuenemann
changed the title
|
OK, I've revised the code to instead set the Host header on the request if missing and added a spec. This is now ready for review! |
|
When will this be merged? In the mean time we'll have merge @felixbuenemann's branch into our own local fork that also has an outstanding PR :( |
|
Thanks @felixbuenemann . #25 was merged and include this fixes also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a
KeyError: Missing hash key: HTTP::Headers::Key(@name="Host")exception if you useHTTP::client#execwith aHTTP::Requestinstance that has no "Host" header set.Fixes #5