Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Make sure ids are always send with the same bit-length #78

Open
Ablu opened this issue Dec 20, 2014 · 1 comment
Open

Make sure ids are always send with the same bit-length #78

Ablu opened this issue Dec 20, 2014 · 1 comment

Comments

@Ablu
Copy link
Member

Ablu commented Dec 20, 2014

For example the lowering an attribute message takes a 32bit int, the raising a 16bit int for the attribute id.

I think we could maybe do a sendId() function which always sends with either 16 or 32bit and make sure that one is always used. (Maybe it would make sense to introduce a type wrapper for ids so they cannot be mixed with integers anywhere (then we also kill all this unsigned <-> signed randomness)

@Ablu
Copy link
Member Author

Ablu commented Dec 20, 2014

Sharing the receive and send code could also help...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant