Use shell=True for linux compat tests to fix feedstock runs
#1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had several issues with CI on conda feedstock runners. They run pytest from a different directory and use environment variables for absolute paths. We tackle both these issues by specifying the requirements file as an absolute path and we explicitly expand variables.
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
IvoDD
changed the title
shell=True for linux compat tests to fix feedstock runs
The issue with conda feedstock runners is they use some variable for abspath, which doesn't get correctly expanded by `os.path.expandvar`. This requires using `shell=True` for linux as well. Also fix the path used for the requirements file.
IvoDD
force-pushed
the
fix-compat-test-on-conda-feedstock
branch
from
0d1305a
to
0dec30e
Compare
IvoDD
added a commit
that referenced
this pull request
Nov 5, 2024
The issue with conda feedstock runners is they use some variable for abspath, which doesn't get correctly expanded by `os.path.expandvar`. This requires using `shell=True` for linux as well. This was tested to properly fix compat tests in #1931 combined with [feedstock pr](conda-forge/arcticdb-feedstock#322). However it still doesn't work for some of the macos builds which are not skipped correctly. Still this is a good change for local runs as well and we'll fix the macos issue in a separate run.
IvoDD
added a commit
that referenced
this pull request
Nov 6, 2024
The issue with conda feedstock runners is they use some variable for abspath, which doesn't get correctly expanded by `os.path.expandvar`. This requires using `shell=True` for linux as well. This was tested to properly fix compat tests in #1931 combined with [feedstock pr](conda-forge/arcticdb-feedstock#322). However it still doesn't work for some of the macos builds which are not skipped correctly. Still this is a good change for local runs as well and we'll fix the macos issue in a separate run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with conda feedstock runners is they use some variable for
abspath, which doesn't get correctly expanded by
os.path.expandvar.This requires using
shell=Truefor linux as well.Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...