Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result of use-macro is placed in the wrong position, when using i18n:translate #419

Open
pgrunewald opened this issue Apr 3, 2024 · 0 comments
Open

Result of use-macro is placed in the wrong position, when using i18n:translate #419

pgrunewald opened this issue Apr 3, 2024 · 0 comments

Comments

@pgrunewald
Copy link

Consider the following HTML snippet:

<tal:fancy-link metal:define-macro="fancy-link">
  <a href="#">
    Fancy link    
  </a>
</tal:fancy-link>

<tal:something i18n:translate="text_with_link">
  Now follows a fancy link: <metal:fancy-link i18n:name="obj_link" use-macro="template/macros/fancy-link" />
</tal:something>

Expected output:

Now follows a fancy link: Fancy link

Current output:

Fancy link Now follows a fancy link:

Noteworthy, when I edit the HTML by removing i18n:translate and i18n:name it places the link the correct position. This does not help, because I want to place the link depending on the translation.

Tested with Chameleon version: 3.9.1
@malthe malthe mentioned this issue Apr 4, 2024
Merged
credfeto added a commit to credfeto/LiveBandPhotosCom that referenced this issue Apr 8, 2024
@credfeto
[Dependencies]: Bump chameleon from 4.5.2 to 4.5.4 (#411)
e83704d 
Bumps [chameleon](https://github.com/malthe/chameleon) from 4.5.2 to
4.5.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/malthe/chameleon/releases">chameleon's
releases</a>.</em></p>
<blockquote>
<h2>4.5.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix issue with multiple dollar escape by <a
href="https://github.com/malthe"><code>@​malthe</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/423">malthe/chameleon#423</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/malthe/chameleon/compare/4.5.3...4.5.4">https://github.com/malthe/chameleon/compare/4.5.3...4.5.4</a></p>
<h2>4.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix issue where macro would not get correctly rendered for a
translation name by <a
href="https://github.com/malthe"><code>@​malthe</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/420">malthe/chameleon#420</a></li>
<li>Minor optimization to translation rendering for static message ids
by <a href="https://github.com/malthe"><code>@​malthe</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/421">malthe/chameleon#421</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/malthe/chameleon/compare/4.5.2...4.5.3">https://github.com/malthe/chameleon/compare/4.5.2...4.5.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/malthe/chameleon/blob/master/CHANGES.rst">chameleon's
changelog</a>.</em></p>
<blockquote>
<h2>4.5.4 (2024-04-08)</h2>
<ul>
<li>Fix an issue where $-sign interpolation escaping would not work
correctly when more than two such symbols appeared next to each
other.
(<code>[#422](malthe/chameleon#422)
&lt;https://github.com/malthe/chameleon/issues/422&gt;</code>_)</li>
</ul>
<h2>4.5.3 (2024-04-05)</h2>
<ul>
<li>
<p>Minor optimization when rendering translations with a static
message id (don't need to test if it's non-empty).</p>
</li>
<li>
<p>Fix a bug where a macro could not be used correctly to render a
translation name.
(<code>[#419](malthe/chameleon#419)
&lt;https://github.com/malthe/chameleon/issues/419&gt;</code>_)</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/malthe/chameleon/commit/10e5d32e7b974cd5150e2963bcf915ebfd6f4683"><code>10e5d32</code></a>
Tagging release</li>
<li><a
href="https://github.com/malthe/chameleon/commit/6a94e9f1063612fb0381e4f9a976d014b78b5b17"><code>6a94e9f</code></a>
Merge pull request <a
href="https://redirect.github.com/malthe/chameleon/issues/423">#423</a>
from malthe/issue-422-interpolation-multiple-escape</li>
<li><a
href="https://github.com/malthe/chameleon/commit/a5bd6650f86b913117adeaf940a466d4e9935e96"><code>a5bd665</code></a>
Fix issue with multiple dollar escape</li>
<li><a
href="https://github.com/malthe/chameleon/commit/1b1277af5dff1f69f04f977ac4743bb54008928c"><code>1b1277a</code></a>
Version bump</li>
<li><a
href="https://github.com/malthe/chameleon/commit/2d399ecb841a0c675e7c1f61a8cf19b2fd05f807"><code>2d399ec</code></a>
Prepare release</li>
<li><a
href="https://github.com/malthe/chameleon/commit/b757a4da544870d4f92904be10c9009f0fce95d6"><code>b757a4d</code></a>
Merge pull request <a
href="https://redirect.github.com/malthe/chameleon/issues/418">#418</a>
from Daverball/minor-type-improvements</li>
<li><a
href="https://github.com/malthe/chameleon/commit/0822ac912fd32feec6577f17bc8ea1146cb6a38c"><code>0822ac9</code></a>
Merge pull request <a
href="https://redirect.github.com/malthe/chameleon/issues/421">#421</a>
from malthe/translate-msgid-check-optimization</li>
<li><a
href="https://github.com/malthe/chameleon/commit/52021502602f0cf642903a35dda2a8dee4176d93"><code>5202150</code></a>
Minor optimization</li>
<li><a
href="https://github.com/malthe/chameleon/commit/0d526455d38b3c1006367ae3a027c8b657b4ee82"><code>0d52645</code></a>
Narrow type for mangle</li>
<li><a
href="https://github.com/malthe/chameleon/commit/c265cbd6ca9c8b56c1646fce184665ea3c1d9409"><code>c265cbd</code></a>
Merge pull request <a
href="https://redirect.github.com/malthe/chameleon/issues/420">#420</a>
from malthe/issue-419</li>
<li>Additional commits viewable in <a
href="https://github.com/malthe/chameleon/compare/4.5.2...4.5.4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chameleon&package-manager=pip&previous-version=4.5.2&new-version=4.5.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgrunewald