Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotation #215

Open
mazlum opened this issue Aug 30, 2022 · 3 comments
Open

add type annotation #215

mazlum opened this issue Aug 30, 2022 · 3 comments

Comments

@mazlum
Copy link

mazlum commented Aug 30, 2022

Do you think adding type annotation completely?

@sebastian-philipp
Copy link
Contributor

what do you miss exacly? Together with django-stubs, this is already super helpful as it is.

@mazlum
Copy link
Author

mazlum commented Aug 31, 2022

There is no type annotation for some functions.

https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/queryset.py#L98

And the latest versions of mypy and django-stubs say: "call to untyped function in typed context"

for .filter function.

@Gagaro
Copy link
Member

Gagaro commented Sep 12, 2022

The idea was to just add the minimum so that mypy could be used with safedelete, but I added a few typings at the same time to bootstrap it.

Feel free to open a PR to add more if you feel like it, I don't think I'll have time to do that anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants