-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to choose repeat spacing #95
Comments
Hello @nekromoff Thanks for reporting this issue. 🙏 In fact, even in the demo on this repository we're using a trick (some space characters) to add some spacing between repeated text, as you can see here : https://github.com/makinacorpus/Leaflet.TextPath/blob/master/docs/example.html#L57 The solution used in the demo is definitely not the prettiest one and is more of a workaround. I like your suggestion, considering it's not breaking the current behavior and just adding some option to format the repeated text. Could you make a PR to add the feature you're using to the next version of this library ? |
Will do, thanks.
…On Sun, Oct 1, 2023 at 9:24 PM babastienne ***@***.***> wrote:
Hello @nekromoff <https://github.com/nekromoff>
Thanks for reporting this issue. 🙏
In fact, even in the demo on this repository we're using a trick (some
space characters) to add some spacing between repeated text, as you can see
here :
https://github.com/makinacorpus/Leaflet.TextPath/blob/master/docs/example.html#L57
The solution used in the demo is definitely not the prettiest one and is
more of a workaround.
I like your suggestion, considering it's not breaking the current behavior
and just adding some option to format the repeated text. Could you make a
PR to add the feature you're using to the next version of this library ?
—
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBHPTPEA5NXMUX3G4A7NJTX5G7QVANCNFSM6AAAAAA5OIPXJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
repeat: true
now does continuous text repeat.I wanted to have a repeat with some spacing between text elements.
My workaround was to add a condition to pad the text with a non-breakable space after line 81:
Now I can do space separated repeat such as:
repeat: 10
and get this (example):This improves map clutter cause by continuous repeat, e.g. it looked like this before:
The text was updated successfully, but these errors were encountered: