Can book gigs that have already happened

[liamquinn14]

Version

v3

Severity

High

Suggested Priority

High

Observed Behaviour

Currently the dates for all of the gigs in our site are in the past - June 2024. Nonetheless, users are still able make bookings for all of them. This is problematic because users may be excited to attend a gig, book a ticket, then realise that they can't actually go because it has already taken place.

Expected Behaviour

There should not be an option to make a booking for gigs that have already taken place. Furthermore, there should be some visual indication that tells the user that the gig's date has already passed. Perhaps the date could be coloured red?

Reproduction Steps

1. Follow setup instructions for the project
2. Run project with python app.py
3. Follow instructions in README.md to create a user
4. Log in as the new user
5. Navigate to /gigs
6. Click on 'More details & booking' for a gig of your choice
7. Buy a ticket

[PaulNGilson]

Unless you can make a good case for this, I think this is going to be a wontfix - we're just building the site, the customer gets to maintain their list of (future) gigs.

[PaulNGilson]

I guess this issue could be split in two - better indications on gigs in the past, vs not being able to book them in the first place?

[liamquinn14]

Thanks for your feedback but I believe we have an obligation to the client to fulfil the requirements of the specification and the user stories they have provided us.

I have just reseeded the database to include a gig with a date in the future - in order to test whether "gigs in the past are displayed differently" (as per the spec) and whether gigs in the past are "clearly labelled" (as per the user stories).

In the current state of the application, past and future gigs are not displayed differently (see screenshot below).

We simply cannot ship while the application doesn't meet the specified requirements. I will add this as a separate issue now.

I will concede that the specification doesn't include guidance on whether or not gigs in the past can be booked. However we should consult with Jo in order to update the specification, since being able to book gigs in the past would inevitably cause unnecessary problems to users.