Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle leaks threads after termination #184

Open
EdNoepel opened this issue Aug 6, 2020 · 0 comments
Open

Lifecycle leaks threads after termination #184

EdNoepel opened this issue Aug 6, 2020 · 0 comments

Comments

@EdNoepel
Copy link
Contributor

EdNoepel commented Aug 6, 2020

After Lifecycle is terminated (via SIGINT or a call to terminate), threads are left dangling, stuck in while True loops which will never complete.

Audit such loops (cursory examination suggests new_block_watch and _start_event_timer are the main culprits) and ensure they cleanly exit. Consider thread.joining them to make disposal more deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant