Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking script for executive votes #2541

Closed
0xldr opened this issue Jan 25, 2024 · 1 comment
Closed

Add checking script for executive votes #2541

0xldr opened this issue Jan 25, 2024 · 1 comment
Assignees
@0xldr
Labels
Dev Developers enhancement New feature or request Executive relates to an executive vote Workflow

Comments

@0xldr
Copy link
Collaborator

0xldr commented Jan 25, 2024 •
edited
Loading

Add script that performs checks done by the frontend here for executive vote Pull Requests: https://github.com/makerdao/governance-portal-v2/blob/master/pages/executive/create.tsx#L65-L74

This streamlines the review process and removes opportunity for error.

Edited to fix link
@0xldr 0xldr added Workflow Dev Developers Executive relates to an executive vote labels Jan 25, 2024
@0xldr 0xldr self-assigned this Jan 25, 2024
@0xldr 0xldr added the enhancement New feature or request label Jan 25, 2024
@0xldr 0xldr mentioned this issue Jan 26, 2024
Merged
@0xldr 0xldr mentioned this issue Feb 5, 2024
Merged
@0xldr
Copy link
Collaborator Author

0xldr commented Feb 5, 2024

working as of: #2553

example: #2554

@0xldr 0xldr closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xldr 0xldr

Labels
Dev Developers enhancement New feature or request Executive relates to an executive vote Workflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xldr