Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Browsers] Casper Wallet | Wallet active origin issues #656

Open
ost-ptk opened this issue Apr 26, 2023 · 1 comment
Open

[All Browsers] Casper Wallet | Wallet active origin issues #656

ost-ptk opened this issue Apr 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ost-ptk
Copy link
Member

ost-ptk commented Apr 26, 2023

Found 2 issues:

  1. Wallet status badge shows disconnect status at the same time playground show connected
  2. Wallet shows a few of the same accounts in the connected sites list for one site

These issues reproduce in Safari, Chrome, and Firefox

The first issue

Pre-conditions:
A vault with an account exists
Wallet unlock

v 1.3.0

STR:

  • Open Safari and navigate to playground
  • Connect wallet to playground
  • Close Safari
  • Open Safari again and navigate to playground

Expected result: You sign in to the playground and wallet shows that you connected
Actual result: Playground shows that you connected but wallet doesn't

Second issue

Pre-conditions:
A vault with an account exists
Wallet unlock
You have 2 accounts

STR:

  • Open Safari and navigate to playground
  • Connect account 1 to playground
  • Close Safari
  • Open Safari again and navigate to playground
  • Switch to account 2
  • Click connect button on playground
  • Connect account 1 to playground again
  • Open connected site list

Expected result: You cannot connect account 1 to the playground again and you see only one account 1 in the connected site list
Actual result: You can connect account 1 a second time to the playground and see two times account 1 in the connected site list

2023-04-26.20.48.22-1.mov
@ost-ptk ost-ptk added the bug Something isn't working label Apr 26, 2023
@ost-ptk ost-ptk changed the title [Safari] Casper Wallet | Playground issues Casper Wallet | Playground issues Apr 26, 2023
@ost-ptk ost-ptk changed the title Casper Wallet | Playground issues [All Browsers] Casper Wallet | Playground issues Apr 26, 2023
@ost-ptk ost-ptk self-assigned this Apr 28, 2023
@ost-ptk ost-ptk changed the title [All Browsers] Casper Wallet | Playground issues [All Browsers] Casper Wallet | Wallet active origin issues Apr 28, 2023
@piotrwitek piotrwitek added this to the 1.3.1 milestone May 2, 2023
@karatnyk
Copy link

karatnyk commented May 2, 2023

Verified on build 1.3.1 as fixed, moving to 'Done'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants