Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks! #2

Open
bengreenier opened this issue Oct 4, 2019 · 3 comments
Open

Thanks! #2

bengreenier opened this issue Oct 4, 2019 · 3 comments

Comments

@bengreenier
Copy link

Hiya - just wanted to let you know that I'd tried a bunch of other release generation actions and they didn't work out for one reason or another, but this one was a perfect fit.

It was also really great to find that the backing code for it is super straightforward and easy to understand.

That's all, thanks again! 🙏👍

@majkrzak
Copy link
Owner

majkrzak commented Oct 6, 2019

Thx, feel free to contribute.

P.S.
master...bengreenier-archive:master
With updateRelease you are not able to update tag and commit sha. That's why recreate option was for

@bengreenier
Copy link
Author

Will do - want to figure out exactly what I need first, that's what you're observing over on master...bengreenier-archive:master

The scenario I have is:

Multiple builds in parallel, one should create the release, and upload artifacts. Others should notice it's created, and add artifacts.

Thanks for the tip - seems i'll need to remove those params from the update call. 👍

@majkrzak
Copy link
Owner

majkrzak commented Oct 6, 2019

Artifact upload path might be handled separatley (without release creation), also you my trigger on the release creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants