Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to manipulate the creation of a Deployment #528

Open
aslakknutsen opened this issue Sep 16, 2020 · 0 comments · May be fixed by #539
Open

Should be able to manipulate the creation of a Deployment #528

aslakknutsen opened this issue Sep 16, 2020 · 0 comments · May be fixed by #539
Assignees
Labels
component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement

Comments

@aslakknutsen
Copy link
Member

Why

Che Server will launch a Workspace by creating a Deployment object. For Ike to route the traffic from a specific Service to this new Deployment we need the ability to manipulate the Deployment object.

What

A MutatingAdmission WebHook should give us the option to add the target Deployment labels to the Workspace Deployment and by that route traffic to it.

Only mutate Deployments that are labeled ike.target=x

@aslakknutsen aslakknutsen added component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement labels Sep 16, 2020
@aslakknutsen aslakknutsen self-assigned this Sep 22, 2020
aslakknutsen added a commit that referenced this issue Sep 24, 2020
…usage

In a normal cli setting we're looking for a Deployment or a DeploymentConfig,
but with the che integration the Deployment already exists so we need to be
able to wait for something else.

related to #528
bartoszmajsak pushed a commit that referenced this issue Sep 24, 2020
@aslakknutsen aslakknutsen linked a pull request Sep 25, 2020 that will close this issue
10 tasks
aslakknutsen added a commit that referenced this issue Nov 17, 2020
Leader election can take a few more seconds so ensure
readiness is not done until leader election is done.

Related to #528
Fixes #546
Fixes #547
@aslakknutsen aslakknutsen modified the milestone: v0.0.5 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant