Add config options for build and python versions. Add configs for windows and linux arm64. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
choose-python-scons
branch
from
5f1183a to
d0fbdcf
Compare
|
I tried adding windows and linux arm64 builds, but they are failing because of binary incompatibility: That's a ToDo for the future. Arm runners are currently an Enterprise feature. The strip problem may be solvable with more infrastructure: https://github.com/electron/electron/blob/main/script/strip-binaries.py#L16-L25 But then, we also run |
Ivorforce
force-pushed
the
choose-python-scons
branch
2 times, most recently
from
b247007 to
13e116a
Compare
maiself
added
enhancement
…ell as python version. Move build files. Unlock windows and linux build configs for arm64.
Ivorforce
force-pushed
the
choose-python-scons
branch
from
13e116a to
bc7f14a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big change. Review required. I haven't tested running this with different python versions yet, will do this later.
Note (I think) the
"python"option available previously didn't do anything, as the environment variable was overridden anyway.