Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions triggered for every pull request, even if no changes to source are made #35

Open
maiself opened this issue Oct 27, 2024 · 3 comments
Labels
build related to the build system enhancement New feature or request

Comments

@maiself
Copy link
Owner

maiself commented Oct 27, 2024

For instance builds are triggered for changes to documentation, but documentation doesn't affect build outcome. Can this be made more selective?

@maiself maiself added enhancement New feature or request build related to the build system labels Oct 27, 2024
@fire
Copy link
Contributor

fire commented Oct 27, 2024

My personal experience is that this is a minor problem and opensource project are donated machine cycles for this. It ensures coverage of all the pull requests.

@fire
Copy link
Contributor

fire commented Oct 27, 2024

Historically, the godot-python-extensions github actions page says the builds take around 1-3 minutes. I'm ok with 10 minutes before we need to optimize.

For comparison, a regular cached build on godot engine organization is 50 minutes. https://github.com/godotengine/godot/actions/runs/11523267962

@fire
Copy link
Contributor

fire commented Oct 27, 2024

Here is the documentation for pull request author requests for ci skip. https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build system enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants