Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(CLI): Return file addresses within archive when uploading a directory #2434

Open
traktion opened this issue Nov 11, 2024 · 1 comment

Comments

@traktion
Copy link

traktion commented Nov 11, 2024

I understand that files are now collated within an archive. I assume there are reasons for this (perhaps performance or cost oriented?), but it is making the upload/download process more difficult in some cases.

However, when an directory is uploaded (as an archive), only the archive address (XOR) is returned. This makes it hard to know how to directly address the files, unless each are uploaded separately. This assumes that directly addressing the files isn't an issue?

Can the CLI return a list of addresses for each item in the archive, along with the archive address itself? Also, can autonomi file list do the same?

@happybeing
Copy link
Contributor

happybeing commented Nov 11, 2024

I agree that this is a problem and have a PR in progress which splits this API into two functions.

One does as now, but is renamed dir_and_archive_upload() and the new function dir_upload() no longer uploads the Archive but returns it so the caller can inspect the content (files uploaded and xor address). This avoids uploading the Archive unnecessarily, which been be done separately if required.

@traktion how about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants