From 89be0520456d274f642f3dc1750f1477fbd8b14e Mon Sep 17 00:00:00 2001 From: Maicon Heck <13810070+maiconheck@users.noreply.github.com> Date: Sat, 27 Mar 2021 21:27:10 +0000 Subject: [PATCH] :wrench: Roslynator.Analyzers removed --- .github/workflows/ci-cd-pipeline.yml | 2 +- src/Krafted/Analyzers/All.ruleset | 3 - src/Krafted/Analyzers/Default.ruleset | 4 - .../Templates/DisabledOnTest.ruleset | 8 - .../Analyzers/Templates/EnabledOnTest.ruleset | 8 - .../Analyzers/Templates/General.ruleset | 205 ------------------ src/Krafted/Analyzers/Test.ruleset | 3 - .../GlobalSuppressions.cs | 8 - .../Krafted.DataAnnotations.csproj | 5 - .../GlobalSuppressions.cs | 1 - .../Krafted.DesignPatterns.csproj | 5 - .../Krafted.Extensions/GlobalSuppressions.cs | 1 - .../Krafted.Extensions.csproj | 5 - .../Krafted.Guards/GlobalSuppressions.cs | 3 - .../Krafted.Guards/Krafted.Guards.csproj | 5 - .../Krafted.IntegrationTest.csproj | 5 - src/Krafted/Krafted.Net/Krafted.Net.csproj | 5 - .../Krafted.UnitTest/Krafted.UnitTest.csproj | 5 - .../Krafted.UnitTests.csproj | 5 - .../GlobalSuppressions.cs | 6 - .../Krafted.ValueObjects.csproj | 5 - 21 files changed, 1 insertion(+), 296 deletions(-) delete mode 100644 src/Krafted/Krafted.DataAnnotations/GlobalSuppressions.cs diff --git a/.github/workflows/ci-cd-pipeline.yml b/.github/workflows/ci-cd-pipeline.yml index eedd94c..7e1b340 100644 --- a/.github/workflows/ci-cd-pipeline.yml +++ b/.github/workflows/ci-cd-pipeline.yml @@ -30,7 +30,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1.5.0 with: - dotnet-version: 5.0.100 + dotnet-version: 3.1.301 source-url: https://nuget.pkg.github.com/maiconheck/index.json env: ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true' diff --git a/src/Krafted/Analyzers/All.ruleset b/src/Krafted/Analyzers/All.ruleset index 7fb86a6..0f8d785 100644 --- a/src/Krafted/Analyzers/All.ruleset +++ b/src/Krafted/Analyzers/All.ruleset @@ -15,9 +15,6 @@ - - - diff --git a/src/Krafted/Analyzers/Default.ruleset b/src/Krafted/Analyzers/Default.ruleset index 5578e4f..da37a79 100644 --- a/src/Krafted/Analyzers/Default.ruleset +++ b/src/Krafted/Analyzers/Default.ruleset @@ -16,10 +16,6 @@ - - - - diff --git a/src/Krafted/Analyzers/Templates/DisabledOnTest.ruleset b/src/Krafted/Analyzers/Templates/DisabledOnTest.ruleset index 071d3ed..038340d 100644 --- a/src/Krafted/Analyzers/Templates/DisabledOnTest.ruleset +++ b/src/Krafted/Analyzers/Templates/DisabledOnTest.ruleset @@ -8,14 +8,6 @@ - - - - - - - - diff --git a/src/Krafted/Analyzers/Templates/EnabledOnTest.ruleset b/src/Krafted/Analyzers/Templates/EnabledOnTest.ruleset index ae62a31..cad9308 100644 --- a/src/Krafted/Analyzers/Templates/EnabledOnTest.ruleset +++ b/src/Krafted/Analyzers/Templates/EnabledOnTest.ruleset @@ -1,12 +1,5 @@ - - - - - - - @@ -14,7 +7,6 @@ - diff --git a/src/Krafted/Analyzers/Templates/General.ruleset b/src/Krafted/Analyzers/Templates/General.ruleset index 289f2d6..a09f187 100644 --- a/src/Krafted/Analyzers/Templates/General.ruleset +++ b/src/Krafted/Analyzers/Templates/General.ruleset @@ -379,209 +379,4 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/Krafted/Analyzers/Test.ruleset b/src/Krafted/Analyzers/Test.ruleset index 78cd5dd..d786a85 100644 --- a/src/Krafted/Analyzers/Test.ruleset +++ b/src/Krafted/Analyzers/Test.ruleset @@ -15,7 +15,4 @@ - - - diff --git a/src/Krafted/Krafted.DataAnnotations/GlobalSuppressions.cs b/src/Krafted/Krafted.DataAnnotations/GlobalSuppressions.cs deleted file mode 100644 index 6128434..0000000 --- a/src/Krafted/Krafted.DataAnnotations/GlobalSuppressions.cs +++ /dev/null @@ -1,8 +0,0 @@ -// This file is used by Code Analysis to maintain SuppressMessage -// attributes that are applied to this project. -// Project-level suppressions either have no target or are given -// a specific target and scoped to a namespace, type, member, etc. - -using System.Diagnostics.CodeAnalysis; - -[assembly: SuppressMessage("Usage", "RCS1221:Use pattern matching instead of combination of 'as' operator and null check.", Justification = "Not applicable", Scope = "member", Target = "~M:Krafted.DataAnnotations.NotEmptyCollectionAttribute.IsValid(System.Object)~System.Boolean")] diff --git a/src/Krafted/Krafted.DataAnnotations/Krafted.DataAnnotations.csproj b/src/Krafted/Krafted.DataAnnotations/Krafted.DataAnnotations.csproj index 7b444d5..e5ca7db 100644 --- a/src/Krafted/Krafted.DataAnnotations/Krafted.DataAnnotations.csproj +++ b/src/Krafted/Krafted.DataAnnotations/Krafted.DataAnnotations.csproj @@ -22,11 +22,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.DesignPatterns/GlobalSuppressions.cs b/src/Krafted/Krafted.DesignPatterns/GlobalSuppressions.cs index abb9f6d..236aaad 100644 --- a/src/Krafted/Krafted.DesignPatterns/GlobalSuppressions.cs +++ b/src/Krafted/Krafted.DesignPatterns/GlobalSuppressions.cs @@ -9,7 +9,6 @@ [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1600:Elements should be documented", Justification = "Internal type that doesn't expose public API", Scope = "type", Target = "~T:Krafted.DesignPatterns.Specifications.NotSpecification`1")] [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1600:Elements should be documented", Justification = "Internal type that doesn't expose public API", Scope = "type", Target = "~T:Krafted.DesignPatterns.Specifications.IdentitySpecification`1")] [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1600:Elements should be documented", Justification = "Internal type that doesn't expose public API", Scope = "type", Target = "~T:Krafted.DesignPatterns.Specifications.AndSpecification`1")] -[assembly: SuppressMessage("Redundancy", "RCS1163:Unused parameter.", Justification = "Not applicable", Scope = "member", Target = "~M:Krafted.DesignPatterns.Specifications.IdentitySpecification`1.ToExpression~System.Linq.Expressions.Expression{System.Func{`0,System.Boolean}}")] [assembly: SuppressMessage("Style", "CC0001:You should use 'var' whenever possible.", Justification = "In this case the explicit type improves readability", Scope = "member", Target = "~M:Krafted.DesignPatterns.Specifications.OrSpecification`1.ToExpression~System.Linq.Expressions.Expression{System.Func{`0,System.Boolean}}")] [assembly: SuppressMessage("Style", "CC0001:You should use 'var' whenever possible.", Justification = "In this case the explicit type improves readability", Scope = "member", Target = "~M:Krafted.DesignPatterns.Specifications.NotSpecification`1.ToExpression~System.Linq.Expressions.Expression{System.Func{`0,System.Boolean}}")] [assembly: SuppressMessage("Style", "CC0001:You should use 'var' whenever possible.", Justification = "In this case the explicit type improves readability", Scope = "member", Target = "~M:Krafted.DesignPatterns.Specifications.AndSpecification`1.ToExpression~System.Linq.Expressions.Expression{System.Func{`0,System.Boolean}}")] diff --git a/src/Krafted/Krafted.DesignPatterns/Krafted.DesignPatterns.csproj b/src/Krafted/Krafted.DesignPatterns/Krafted.DesignPatterns.csproj index 04c1ce8..39127b9 100644 --- a/src/Krafted/Krafted.DesignPatterns/Krafted.DesignPatterns.csproj +++ b/src/Krafted/Krafted.DesignPatterns/Krafted.DesignPatterns.csproj @@ -18,10 +18,5 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.Extensions/GlobalSuppressions.cs b/src/Krafted/Krafted.Extensions/GlobalSuppressions.cs index 25744d1..de73eb7 100644 --- a/src/Krafted/Krafted.Extensions/GlobalSuppressions.cs +++ b/src/Krafted/Krafted.Extensions/GlobalSuppressions.cs @@ -7,6 +7,5 @@ [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:System.Net.Http.HttpResponseMessageExtension.EnsureContentType(System.Net.Http.HttpResponseMessage,System.String)~System.Net.Http.HttpResponseMessage")] [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:System.Net.Http.HttpResponseMessageExtension.DeserializeAsync``1(System.Net.Http.HttpResponseMessage,System.Boolean)~System.Threading.Tasks.Task{``0}")] -[assembly: SuppressMessage("Usage", "RCS1186:Use Regex instance instead of static method.", Justification = "Not applicable", Scope = "member", Target = "~M:System.StringExtension.ToSlug(System.String,System.Int32)~System.String")] [assembly: SuppressMessage("Globalization", "CA1308:Normalize strings to uppercase", Justification = "Not applicable", Scope = "member", Target = "~M:System.StringExtension.ToSlug(System.String,System.Int32)~System.String")] [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:System.Collections.Generic.ListExtension.Move``1(System.Collections.Generic.IList{``0},System.Int32,System.Int32)")] diff --git a/src/Krafted/Krafted.Extensions/Krafted.Extensions.csproj b/src/Krafted/Krafted.Extensions/Krafted.Extensions.csproj index 6bbf86e..3f39270 100644 --- a/src/Krafted/Krafted.Extensions/Krafted.Extensions.csproj +++ b/src/Krafted/Krafted.Extensions/Krafted.Extensions.csproj @@ -23,11 +23,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.Guards/GlobalSuppressions.cs b/src/Krafted/Krafted.Guards/GlobalSuppressions.cs index 5c98a0a..2c049a6 100644 --- a/src/Krafted/Krafted.Guards/GlobalSuppressions.cs +++ b/src/Krafted/Krafted.Guards/GlobalSuppressions.cs @@ -6,8 +6,5 @@ using System.Diagnostics.CodeAnalysis; [assembly: SuppressMessage("Style", "CC0037:Remove commented code.", Justification = "This comment is a header documentation")] -[assembly: SuppressMessage("Design", "RCS1225:Make class sealed.", Justification = "Not applicable", Scope = "type", Target = "~T:Krafted.Guards.Guard")] [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1609:Property documentation should have value", Justification = "Not applicable", Scope = "member", Target = "~P:Krafted.Guards.Guard.Against")] [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1623:Property summary documentation should match accessors", Justification = "Not applicable", Scope = "member", Target = "~P:Krafted.Guards.Guard.Against")] -[assembly: SuppressMessage("Usage", "RCS1221:Use pattern matching instead of combination of 'as' operator and null check.", Justification = "Not Applicable", Scope = "member", Target = "~M:Krafted.DataAnnotations.NotEmptyCollectionAttribute.IsValid(System.Object)~System.Boolean")] -[assembly: SuppressMessage("Redundancy", "RCS1175:Unused this parameter.", Justification = "Needed for extension method", Scope = "member", Target = "~M:System.EnumExtension.GetName``1(System.Enum,System.Object)~System.String")] diff --git a/src/Krafted/Krafted.Guards/Krafted.Guards.csproj b/src/Krafted/Krafted.Guards/Krafted.Guards.csproj index 2e6c520..ae9d556 100644 --- a/src/Krafted/Krafted.Guards/Krafted.Guards.csproj +++ b/src/Krafted/Krafted.Guards/Krafted.Guards.csproj @@ -18,11 +18,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.IntegrationTest/Krafted.IntegrationTest.csproj b/src/Krafted/Krafted.IntegrationTest/Krafted.IntegrationTest.csproj index 55bb0e0..6cab09e 100644 --- a/src/Krafted/Krafted.IntegrationTest/Krafted.IntegrationTest.csproj +++ b/src/Krafted/Krafted.IntegrationTest/Krafted.IntegrationTest.csproj @@ -40,11 +40,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.Net/Krafted.Net.csproj b/src/Krafted/Krafted.Net/Krafted.Net.csproj index c7e7eeb..386bce6 100644 --- a/src/Krafted/Krafted.Net/Krafted.Net.csproj +++ b/src/Krafted/Krafted.Net/Krafted.Net.csproj @@ -19,11 +19,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.UnitTest/Krafted.UnitTest.csproj b/src/Krafted/Krafted.UnitTest/Krafted.UnitTest.csproj index aca46b1..9d861c4 100644 --- a/src/Krafted/Krafted.UnitTest/Krafted.UnitTest.csproj +++ b/src/Krafted/Krafted.UnitTest/Krafted.UnitTest.csproj @@ -41,11 +41,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.UnitTests/Krafted.UnitTests.csproj b/src/Krafted/Krafted.UnitTests/Krafted.UnitTests.csproj index af12760..64f41bd 100644 --- a/src/Krafted/Krafted.UnitTests/Krafted.UnitTests.csproj +++ b/src/Krafted/Krafted.UnitTests/Krafted.UnitTests.csproj @@ -25,11 +25,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all - diff --git a/src/Krafted/Krafted.ValueObjects/GlobalSuppressions.cs b/src/Krafted/Krafted.ValueObjects/GlobalSuppressions.cs index a022fb9..830d01c 100644 --- a/src/Krafted/Krafted.ValueObjects/GlobalSuppressions.cs +++ b/src/Krafted/Krafted.ValueObjects/GlobalSuppressions.cs @@ -5,14 +5,8 @@ using System.Diagnostics.CodeAnalysis; -[assembly: SuppressMessage("General", "RCS1181:Convert comment to documentation comment.", Justification = "In this case, it's just a comment, and not a documentation comment.", Scope = "member", Target = "~M:Krafted.ValueObjects.Money.#ctor")] -[assembly: SuppressMessage("General", "RCS1181:Convert comment to documentation comment.", Justification = "In this case, it's just a comment, and not a documentation comment.", Scope = "member", Target = "~M:Krafted.ValueObjects.Pt.Nif.#ctor")] -[assembly: SuppressMessage("General", "RCS1181:Convert comment to documentation comment.", Justification = "In this case, it's just a comment, and not a documentation comment.", Scope = "member", Target = "~M:Krafted.ValueObjects.Email.#ctor")] -[assembly: SuppressMessage("General", "RCS1181:Convert comment to documentation comment.", Justification = "In this case, it's just a comment, and not a documentation comment.", Scope = "member", Target = "~M:Krafted.ValueObjects.Url.#ctor")] [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:Krafted.ValueObjects.Money.op_Addition(Krafted.ValueObjects.Money,System.Decimal)~Krafted.ValueObjects.Money")] [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:Krafted.ValueObjects.Money.op_Subtraction(Krafted.ValueObjects.Money,System.Decimal)~Krafted.ValueObjects.Money")] [assembly: SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Guard.Against", Scope = "member", Target = "~M:Krafted.ValueObjects.Money.op_Implicit(Krafted.ValueObjects.Money)~System.Decimal")] [assembly: SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "Not applicable", Scope = "member", Target = "~M:Krafted.ValueObjects.Money.ToString~System.String")] -[assembly: SuppressMessage("Usage", "RCS1206:Use conditional access instead of conditional expression.", Justification = "Not applicable", Scope = "member", Target = "~M:Krafted.ValueObjects.ValueObject.GetHashCode~System.Int32")] [assembly: SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1649:File name should match first type name", Justification = "This is a common way to name files that correspond to a generic type. The number after ` correspond to the quantity of generic arguments.", Scope = "type", Target = "~T:Krafted.ValueObjects.ValueObject`1")] -[assembly: SuppressMessage("Usage", "RCS1206:Use conditional access instead of conditional expression.", Justification = "Not applicable", Scope = "member", Target = "~M:Krafted.ValueObjects.ValueObject`1.GetHashCode~System.Int32")] diff --git a/src/Krafted/Krafted.ValueObjects/Krafted.ValueObjects.csproj b/src/Krafted/Krafted.ValueObjects/Krafted.ValueObjects.csproj index 4b4305f..0b0f1a7 100644 --- a/src/Krafted/Krafted.ValueObjects/Krafted.ValueObjects.csproj +++ b/src/Krafted/Krafted.ValueObjects/Krafted.ValueObjects.csproj @@ -19,11 +19,6 @@ runtime; build; native; contentfiles; analyzers all - - - runtime; build; native; contentfiles; analyzers - all -