SecretBlock secrets not obfuscated

[hanscgruber]

using PrefectInterfaces
import PrefectInterfaces: SecretBlock

sblk = SecretBlock("poo", "patype", "abc123")
SecretBlock("poo", "patype", ####Secret####)

show(sblk)
SecretBlock("poo", "patype", ####Secret####)
dump(sblk)
SecretBlock
  blockname: String "poo"
  blocktype: String "patype"
  value: SecretString
    secret: String "abc123"

The existing method definition is not effective, move it up to a higher level of the Base.dump method definition.

Base.dump(io::IO, s::SecretString; maxdepth=1) = print(io, "SecretString")

# should be

Base.dump(io::IOContext, s::SecretString, n::Int64, indent) = print(io, "SecretString")

Then the recursive dump definition will pick this up when it finds a SecretString.

[hanscgruber]

# prefectblocktypes.jl

Base.dump(io::IOContext, s::SecretString, n::Int64, indent) = print(io, "SecretString")

Now it works fine

sblk = SecretBlock("poo", "patype", "abc123")
SecretBlock("poo", "patype", ####Secret####)

dump(sblk)
SecretBlock
  blockname: String "poo"
  blocktype: String "patype"
  value: SecretString

dump(sblk; maxdepth = 8)
SecretBlock
  blockname: String "poo"
  blocktype: String "patype"
  value: SecretString

sblk.value
####Secret####

dump(sblk.value)
SecretString

sblk.value.secret
"abc123"

[mahiki]

It works, good job everybody. Now gotta figure out how TagBot works and get the release to go.