From 3e3f5dae152589a96a9a3d575ae79c99946f2b95 Mon Sep 17 00:00:00 2001
From: Bart Brouns <bart@magnetophon.nl>
Date: Thu, 19 Dec 2024 08:58:51 +0100
Subject: [PATCH] better defaults, clean todods

---
 src/lib.rs | 15 ++++++++-------
 todo.org   | 13 ++-----------
 2 files changed, 10 insertions(+), 18 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 72c88f5..bbf7a6f 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -244,7 +244,7 @@ impl GlobalParams {
             .with_string_to_value(Del2::s2v_f32_ms_then_s()),
             release_ms: FloatParam::new(
                 "Release",
-                420.0,
+                13.0,
                 FloatRange::Skewed {
                     min: 5.0,
                     max: 20_000.0,
@@ -376,7 +376,7 @@ impl TapsParams {
 
             cutoff_main: FloatParam::new(
                 format!("cutoff"),
-                3_003.0,
+                1_690.0,
                 FloatRange::Skewed {
                     min: 10.0,
                     max: 18_000.0,
@@ -391,7 +391,7 @@ impl TapsParams {
             })),
             res_main: FloatParam::new(
                 format!("resonance"),
-                0.42,
+                0.13,
                 FloatRange::Linear { min: 0., max: 1. },
             )
             .with_value_to_string(formatters::v2s_f32_rounded(2))
@@ -415,7 +415,7 @@ impl TapsParams {
 
             cutoff_mod: FloatParam::new(
                 format!("cutoff mod"),
-                0.0,
+                0.13,
                 FloatRange::Linear {
                     min: -1.0,
                     max: 1.0,
@@ -430,7 +430,7 @@ impl TapsParams {
             })),
             res_mod: FloatParam::new(
                 format!("resonance mod"),
-                0.13,
+                0.0,
                 FloatRange::Linear {
                     min: -1.0,
                     max: 1.0,
@@ -447,10 +447,11 @@ impl TapsParams {
             drive_mod: FloatParam::new(
                 format!("drive mod"),
                 13.0,
-                FloatRange::Skewed {
-                    min: 0.0,
+                FloatRange::SymmetricalSkewed {
+                    min: -42.0,
                     max: 42.0,
                     factor: FloatRange::skew_factor(-1.0),
+                    center: 0.0,
                 },
             )
             .with_step_size(0.1)
diff --git a/todo.org b/todo.org
index 0d8a61d..76f203a 100644
--- a/todo.org
+++ b/todo.org
@@ -1,20 +1,13 @@
 #+title: Todo
 
 
-* instead of low-high vel, have a main param and a modulation amount
 * make offset smaller
 * make modulation a curve param, with view like vital?
 * make modulation a curve editor?
-* remove "vel>cut" and "note>cut", replace by "cutoff mod" button that chooses between note and velocity
-when you choose "note", you get an octave (and a transpose) knob instead of the normal cutoff controls
 * increase meter range, add pre-delay low cut
-* remove per tap mode switch
 * maybe add dry/wet for filters
 * make attack and release continuously update
 * increase minimal attack and release
-* make caption "easy mode" and "expert mode"
-* max tap -> timeout
-* min tap -> debounce
 * offset/amount  -> amount/offset
 * simd smoother, for up to 8 smoothers at once!
 * README: add chorus trick and gated delay example
@@ -23,13 +16,11 @@ when you choose "note", you get an octave (and a transpose) knob instead of the
 * downgrade macos (& ubuntu?)
 * friendly welcome text on first open
 * make easy/expert a normal slider
+* resize window on easy/expert change, so that button stays in the same place
 * note> pan:  make it a range and adjust zoom range to it?
 * make loop trigger
 * make bpm sync the default (maybe check (at init?if tempo available)
-* dezip drive
-* make drive_main gain compensated, but drive_mod not
-* check clap of skia
-* don't create a new smoother on every new tap
+* don't create a new smoother on every new tap?
 * smarter s2v seconds: if s < max seconds: interpret as seconds else as ms     or just always as sec?
 * make attack and release Exponential?
 * see which param needs an Arc and why