Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge not pulling updated version of a PR #180

Closed
gautammohan opened this issue Aug 9, 2019 · 2 comments
Closed

Forge not pulling updated version of a PR #180

gautammohan opened this issue Aug 9, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@gautammohan
Copy link

gautammohan commented Aug 9, 2019

Hi there,

I just started using forge and it's great! I am running into an issue where an open PR on Github is not reflecting the latest version in forge. On Github, the PR has a few comments and a review request, but the version shown in magit on my local machine only has the diffs + first comment. The "review-requests" field is empty, and it only has one comment, despite there being 2 more displayed on github.

I have tried forge-reset-database several times before running forge-pull, but that did not help.

Do you have any suggestions of steps I can take to debug/diagnose this issue? Unfortunately the repository I am referencing is private, but I could perhaps try and repro this behavior on a fresh public repo if you think that would help.

@gautammohan
Copy link
Author

I should also note that the comments in question are "review comments", I think? They refer to specific diffs of the PR, and are not left on the main thread of the PR, if that makes sense. Sorry for not being totally clear, I am unfamiliar with the exact github terms to describe these things...

@tarsius
Copy link
Member

tarsius commented Aug 9, 2019

I should also note that the comments in question are "review comments", I think?

Indeed. Forge doesn't support those yet. The feature request for that is #75.

@tarsius tarsius closed this as completed Aug 9, 2019
@tarsius tarsius added the duplicate This issue or pull request already exists label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants