Clean-up "comment" functions

In the code all the "comment" are treated as a post object.
A post object can be found in a pull-request or an issue for eg.

To avoid confusion it makes more sense to use "post" instead of
"comment" in the function name when handling post object.

Also forge-comment-at-point function has been removed since it's not
used.

Signed-off-by: Julien Masson <[email protected]>

lisp/forge-commands.el

@@ -605,12 +605,12 @@ topic N and modify that instead."
 
 ;;; Delete
 
-(defun forge-delete-comment (comment)
-  "Delete the comment at point."
-  (interactive (list (or (forge-comment-at-point)
-                         (user-error "There is no comment at point"))))
-  (when (yes-or-no-p "Do you really want to delete the selected comment? ")
-    (forge--delete-comment (forge-get-repository t) comment)))
+(defun forge-delete-post (post)
+  "Delete the post at point."
+  (interactive (list (or (forge-post-at-point)
+                         (user-error "There is no post at point"))))
+  (when (yes-or-no-p "Do you really want to delete the selected post ? ")
+    (forge--delete-post (forge-get-repository t) post)))
 
 ;;; Branch
 

lisp/forge-github.el

@@ -702,7 +702,7 @@
     :payload labels
     :callback (forge--set-field-callback)))
 
-(cl-defmethod forge--delete-comment
+(cl-defmethod forge--delete-post
   ((_repo forge-github-repository) post)
   (forge--ghub-delete post "/repos/:owner/:repo/issues/comments/:number")
   (closql-delete post)

lisp/forge-gitlab.el

@@ -666,7 +666,7 @@
        (forge--set-topic-field repo topic 'assignee_ids
                                (--map (caddr (assoc it users)) assignees))))))
 
-(cl-defmethod forge--delete-comment
+(cl-defmethod forge--delete-post
   ((_repo forge-gitlab-repository) post)
   (forge--glab-delete post
     (cl-etypecase post

lisp/forge-post.el

@@ -65,13 +65,6 @@
 (defun forge-post-at-point ()
   (magit-section-value-if '(issue pullreq post)))
 
-(defun forge-comment-at-point ()
-  (and (magit-section-value-if '(post))
-       (let ((post (oref (magit-current-section) value)))
-         (and (or (forge-pullreq-post-p post)
-                  (forge-issue-post-p post))
-              post))))
-
 (defun forge-topic-at-point ()
   (or (magit-section-value-if '(issue pullreq))
       (when-let ((branch (magit-branch-at-point)))

lisp/forge-topic.el

@@ -388,7 +388,7 @@ identifier."
   (let ((map (make-sparse-keymap)))
     (define-key map [remap magit-browse-thing] 'forge-browse-post)
     (define-key map [remap magit-edit-thing]   'forge-edit-post)
-    (define-key map (kbd "C-c C-k")            'forge-delete-comment)
+    (define-key map (kbd "C-c C-k")            'forge-delete-post)
     (define-key map (kbd "C-c C-r")            'forge-reply-post)
     map))