Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows release binary as an executable and not as an archive #263

Open
kernelPanic0x opened this issue Oct 9, 2024 · 2 comments
Open

Windows release binary as an executable and not as an archive #263

kernelPanic0x opened this issue Oct 9, 2024 · 2 comments

Comments

@kernelPanic0x
Copy link
Contributor

What is the reason for the windows binary release to be .tgz? Wouldn't it be easier if the downlaod would be an executable right away? I am not sure if all windows users are familiar with .tar.gz files 😆.
@felinira
Copy link
Collaborator

The linux binaries are in a .tar.gz file because they need to preserve the executable bit. I don't know about windows, but I want to stay compatible to cargo-binstall. Considering https://github.com/xd009642/tarpaulin/releases also has a zip file on windows, we could probably use zip instead.

@felinira
Copy link
Collaborator

Contributions to change the CI to build zip files on windows would be accepted. I suppose we could be using https://github.com/taiki-e/upload-rust-binary-action which seems to do this automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felinira @kernelPanic0x