-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CE 2.2.X Configurable product with 1 Attribute - Display Out of Stock Products #15047
Comments
We have the same issue with simple products that are shown in a dropdown attribute. "Display out of stock products" = yes, but they do not appear in the dropdown on a configurable product detail page. Even after reindexing/clearing cache. |
still a problem in CE 2.2.4 |
Edit: The following is for <= 2.2.4. This has since been changed in 2.2.5 The cause seems to be I personally fixed it with a custom module di.xml though I doubt that this is always the right solution since this for example doesn't check if backorders are allowed for a specific attribute . Maybe someone else has a more prominent solution?
Vendor\MyModule\Plugin\Magento\ConfigurableProduct\Attribute\InStockOptionSelectBuilder.php
|
@sduif i've follow your instruction, but it doesn't work on magento 2.2.5 |
Correct, unfortunately there have been various changes in 2.2.5 that break the suggested fix. I've updated my comment to reflect this. I'm affraid I do not have an alternative fix at this time. |
@sduif thanks you, i've searching for this issue all day long and find a lot of code and suggestion, but none of them work so far. |
The bug is still present, with a configurable and only one attribute, please reopen the issue. |
I don't believe this to be a bug. It's more just how they've decided to handle this logic. That said, I would like an option to show sold out sizes on items with just one attribute. |
This is not a duplicate of that issue. That issue was closed because they didn't try reproducing it correctly. They tried on a product with more than one configurable attributes. They need to try on a product with only a single configurable attribute -- as the very title of this issue says! @magento-engcom-team or @engcom-Charlie Please re-open this issue. |
@magento give me 2.4-develop instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @ihor-sviziev, here is your Magento instance. |
Re-opening because of #27368. Looks like this issue was closed not correctly and have to be re-checked |
Hi @kinhcan @diamondavocado, On category page configurable product is shown: But when I enabled one single product - it started to show "in stock" and it started showing drop-down with attribute selection: As for me it works as expected. Do you agree? |
Hi @ihor-sviziev. Thank you for working on this issue.
|
Hi @kinhcan, |
Hi @kinhcan, Unfortunately, I don't have information on which exactly changes fixed it. |
🤯 Glad the issue is sorted, but... definitely, I'd love to know which Commit fixes that or what Quality Patch offers the fix. magento2/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php Lines 1291 to 1300 in bf4cdad
Where the false in 1294 line stands for excluding out-of-stock products.
|
Hi @lbajsarowicz. Thank you for your request. Comments like |
Hi @lbajsarowicz. Thank you for your request. I'm working on Magento instance for you. |
Hi @lbajsarowicz, here is your Magento Instance: https://1a7cac06c8fc2990b65c8f45d77618c2-2-4-develop.instances.magento-community.engineering |
Reopened since we have a report that issue still reproducing on the 2.4-develop branch |
@mrtuvn I used the test instance that Magento built. |
Hi @engcom-November. Thank you for working on this issue.
|
@mrtuvn you have to test with a product with only 1 configurable attribute. |
Thanks @mrtuvn for check it out, I think te issue can finally been closed now 🎉 |
@lbajsarowicz, could you provide more info on how you reproduced it? Thank you! |
Ignore it. We fixed that locally on the project. |
Thanks for your update @mrtuvn. Closing the ticket as the issue is resolved. |
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: