Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add a ruleset reference #64

Open
barbazul opened this issue Jul 27, 2021 · 4 comments
Open

Request: Add a ruleset reference #64

barbazul opened this issue Jul 27, 2021 · 4 comments
Assignees

Comments

@barbazul
Copy link

PHP Semver Checker has one https://github.com/tomzx/php-semver-checker/blob/master/docs/Ruleset.md and is pretty handy for quickly checking before making a change.

In most cases where there is already a version constraint set it is very inconvenient to have to make the change, then run the tool, then have to rollback parts of the work done to avoid breaking changes.

The ruleset could be a simple md file referencing the original ruleset, specifying the few overrides and explaining all the custom Magento 2 rules being added

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2021

Hi @barbazul. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@barbazul
Copy link
Author

barbazul commented Oct 5, 2021

@magento I am working on this

@barbazul
Copy link
Author

barbazul commented Oct 5, 2021

As I am currently working on documenting a Ruleset.md file I detected some issues .

I have found a discrepancy in code format. Some rules follow the format MXYZ like M123 and some others follow M0XYZ like M0123 which leads to some pseudo-collisions like

Code Level Rule
M0122 MAJOR Extends has been removed.
M122 PATCH [private] Method return typing changed.

Some other cases actually collide. So far the only example I have found is rule M108 which is duplicated both classes refer to the same situation (a DB foreign key being dropped/removed).
I am documenting these as 2 rows like the following:

Code Level Rule
M108 MAJOR Foreign key removed from declaration but it may have had business logic in onDelete statement
M108 MAJOR Foreign key was removed

@barbazul
Copy link
Author

barbazul commented Oct 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant