[eslint] Allow use of double quotes where sensible #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
changed the title
fredden
force-pushed
the
eslint-quotes
branch
from
a5b8698
to
7d5284d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small part of #347 as suggested in #347 (comment).
https://eslint.org/docs/rules/quotes
This is a minor change to the existing rule to allow the use of double quotes where it's sensible to do so. For example, the current rule configuration means that
"It's sensible to use double quotes here."must instead be written as'It\'s sensible to use double quotes here.'. As JavaScript does not interpolate strings the same way as PHP (where'and"mean different things), there is no harm in using the most sensible quote type. We're preserving the default preference of using single quotes by default / where possible.