Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint configuration #347

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update ESLint configuration #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2787b5e
Update ESLint configuration
fredden Sep 20, 2023
662113b
Update existing files to match new coding standard
fredden Sep 20, 2023
8c6374a
Also allow more modern syntax & objects
fredden Sep 20, 2023
a1766bf
Avoid conflict: mixed-operators / extra-parens
fredden Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 84 additions & 7 deletions eslint/.eslintrc-magento
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,26 @@
"node": true
},
"rules": {
"comma-dangle": [2, "never"],
"array-bracket-spacing": [2, "never"],
"arrow-spacing": [2, {"after": true, "before": true}],
"block-spacing": [2, "always"],
"brace-style": [2, "1tbs", {"allowSingleLine": true}],
"comma-dangle": [ 2, "always-multiline" ],
"comma-spacing": [2, {"after": true, "before": false}],
"comma-style": [2, "last"],
"constructor-super": 2,
"curly": [2, "all"],
"dot-location": [2, "property"],
"dot-notation": [2, {"allowKeywords": true}],
"eol-last": 2,
"eqeqeq": [2, "smart"],
"func-call-spacing": [2, "never"],
"generator-star-spacing": [2, {"after": true, "before": true}],
"guard-for-in": 2,
"indent": [2, 4],
"key-spacing": [2, {"afterColon": true, "beforeColon": false}],
"keyword-spacing": [2, {"after": true, "before": true}],
"linebreak-style": [2, "unix"],
"lines-around-comment": [
2,
{
Expand All @@ -28,25 +40,42 @@
"allowObjectStart": true
}
],
"lines-between-class-members": [2, "always", {"exceptAfterSingleLine": true}],
"max-depth": [2, 2],
"max-len": [2, 120, 4],
"max-nested-callbacks": [2, 3],
"multiline-ternary": [2, "always-multiline"],
"new-cap": [2, {"capIsNew": false, "newIsCap": true, "properties": true}],
"new-parens": 2,
"newline-after-var": 2,
"no-alert": 2,
"no-array-constructor": 2,
"no-caller": 2,
"no-case-declarations": 2,
"no-catch-shadow": 2,
"no-class-assign": 2,
"no-compare-neg-zero": 2,
"no-cond-assign": 2,
"no-console": 2,
"no-const-assign": 2,
"no-constant-condition": 2,
"no-control-regex": 2,
"no-debugger": 2,
"no-delete-var": 2,
"no-dupe-args": 2,
"no-dupe-class-members": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-else-return": 2,
"no-empty-character-class": 2,
"no-empty-pattern": 2,
"no-empty": [2, {"allowEmptyCatch": true}],
"no-eval": 2,
"no-ex-assign": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
"no-extra-boolean-cast": 2,
"no-extra-parens": 2,
"no-extra-parens": [2, "all", { "nestedBinaryExpressions": false }],
"no-extra-semi": 2,
"no-fallthrough": 2,
"no-floating-decimal": 2,
Expand All @@ -55,25 +84,53 @@
"no-implied-eval": 2,
"no-inner-declarations": 2,
"no-invalid-regexp": 2,
"no-irregular-whitespace": 2,
"no-iterator": 2,
"no-labels": [2, {"allowLoop": false, "allowSwitch": false}],
"no-lone-blocks": 2,
"no-lonely-if": 2,
"no-loop-func": 2,
"no-mixed-operators": [2, {"allowSamePrecedence": true, "groups": [["==", "!=", "===", "!==", ">", ">=", "<", "<="], ["&&", "||"], ["in", "instanceof"]]}],
"no-mixed-spaces-and-tabs": 2,
"no-multi-spaces": 2,
"no-multi-str": 2,
"no-multiple-empty-lines": 2,
"no-multiple-empty-lines": [2, {"max": 1, "maxEOF": 0}],
"no-native-reassign": 2,
"no-negated-in-lhs": 2,
"no-new-func": 2,
"no-new-object": 2,
"no-new-symbol": 2,
"no-new-wrappers": 2,
"no-new": 2,
"no-obj-calls": 2,
"no-octal-escape": 2,
"no-octal": 2,
"no-proto": 2,
"no-prototype-builtins": 2,
"no-redeclare": 2,
"no-regex-spaces": 2,
"no-return-assign": 2,
"no-self-assign": [2, {"props": true}],
"no-self-compare": 2,
"no-sequences": 2,
"no-shadow": 2,
"no-shadow-restricted-names": 2,
"no-sparse-arrays": 2,
"no-tabs": 2,
"no-template-curly-in-string": 2,
"no-this-before-super": 2,
"no-throw-literal": 2,
"no-trailing-spaces": 2,
"no-undef": 2,
"no-undef-init": 2,
"no-unexpected-multiline": 2,
"no-unmodified-loop-condition": 2,
"no-unneeded-ternary": [2, {"defaultAssignment": false}],
"no-unreachable": 2,
"no-unsafe-finally": 2,
"no-unsafe-negation": 2,
"no-unused-expressions": [2, {"allowShortCircuit": true, "allowTaggedTemplates": true, "allowTernary": true}],
"no-unused-labels": 2,
"no-unused-vars": [
2,
{
Expand All @@ -89,22 +146,42 @@
"no-useless-escape": 2,
"no-useless-rename": 2,
"no-useless-return": 2,
"no-var": 2,
"no-void": 2,
"no-whitespace-before-property": 2,
"no-with": 2,
"one-var": [2, "always"],
"object-curly-newline": [2, {"consistent": true, "multiline": true}],
"object-curly-spacing": [2, "always"],
"object-property-newline": [2, {"allowMultiplePropertiesPerLine": true}],
"one-var": [2, {"initialized": "never"}],
"operator-assignment": [2, "always"],
"quotes": [2, "single", {"allowTemplateLiterals": true}],
"operator-linebreak": [2, "after", {"overrides": {":": "before", "?": "before", "|>": "before"}}],
"padded-blocks": [2, {"blocks": "never", "classes": "never", "switches": "never"}],
"prefer-const": [2, {"destructuring": "all"}],
"prefer-promise-reject-errors": 2,
"quote-props": [2, "as-needed"],
"quotes": [2, "single", {"allowTemplateLiterals": true, "avoidEscape": true}],
"radix": 2,
"require-yield": 2,
"rest-spread-spacing": [2, "never"],
"semi": [2, "always"],
"semi-spacing": 2,
"space-before-blocks": [2, "always"],
"space-before-function-paren": [2, {"anonymous": "always", "named": "never", "asyncArrow": "always"}],
"space-before-function-paren": [2, "always"],
"space-in-parens": [2, "never"],
"space-infix-ops": 2,
"space-unary-ops": [2, {"words": false, "nonwords": false}],
"space-unary-ops": [2, {"nonwords": false, "words": true}],
"spaced-comment": [2, "always", {"block": {"balanced": true, "exceptions": ["*"], "markers": ["*package", "!", ",", ":", "::", "flow-include"]}, "line": {"markers": ["*package", "!", "/", ",", "="]}}],
"strict": ["error", "function"],
"symbol-description": 2,
"template-curly-spacing": [2, "never"],
"template-tag-spacing": [2, "never"],
"unicode-bom": [2, "never"],
"use-isnan": 2,
"valid-typeof": 2,
"vars-on-top": 2,
"wrap-iife": [2, "any", {"functionPrototypeMethods": true}],
"yield-star-spacing": [2, "both"],
"yoda": [2, "never"]
}
}
18 changes: 9 additions & 9 deletions eslint/rules/jquery-no-andSelf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ module.exports = {
description: 'Disallow the use of the deprecated `andSelf` method',
category: 'jQuery deprecated functions',
recommended: true,
url: 'https://api.jquery.com/andself/'
url: 'https://api.jquery.com/andself/',
},
schema: [],
messages: {
andSelf: 'jQuery.andSelf() removed, use jQuery.addBack()'
}
andSelf: 'jQuery.andSelf() removed, use jQuery.addBack()',
},
},

/**
Expand All @@ -22,7 +22,7 @@ module.exports = {
create: function (context) {
'use strict';

var utils = require('./utils.js');
const utils = require('./utils.js');

return {
/**
Expand All @@ -31,17 +31,17 @@ module.exports = {
* @param {Object} node - The node to check.
*/
CallExpression: function (node) {
if (node.callee.type !== 'MemberExpression') {return;}
if (node.callee.type !== 'MemberExpression') { return; }

if (node.callee.property.name !== 'andSelf') {return;}
if (node.callee.property.name !== 'andSelf') { return; }

if (utils.isjQuery(node)) {
context.report({
node: node,
messageId: 'andSelf'
messageId: 'andSelf',
});
}
}
},
};
}
},
};
18 changes: 9 additions & 9 deletions eslint/rules/jquery-no-bind-unbind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ module.exports = {
description: 'Disallow the use of the deprecated $.bind and $.unbind',
category: 'jQuery deprecated functions',
recommended: true,
url: 'https://api.jquery.com/bind/'
url: 'https://api.jquery.com/bind/',
},
schema: [],
messages: {
bind: 'jQuery $.bind and $.unbind are deprecated, use $.on and $.off instead'
}
bind: 'jQuery $.bind and $.unbind are deprecated, use $.on and $.off instead',
},
},

/**
Expand All @@ -22,7 +22,7 @@ module.exports = {
create: function (context) {
'use strict';

var utils = require('./utils.js');
const utils = require('./utils.js');

return {
/**
Expand All @@ -31,17 +31,17 @@ module.exports = {
* @param {Object} node - The node to check.
*/
CallExpression: function (node) {
if (node.callee.type !== 'MemberExpression') {return;}
if (node.callee.type !== 'MemberExpression') { return; }

if (!['bind', 'unbind'].includes(node.callee.property.name)) {return;}
if (!['bind', 'unbind'].includes(node.callee.property.name)) { return; }

if (utils.isjQuery(node)) {
context.report({
node: node,
messageId: 'bind'
messageId: 'bind',
});
}
}
},
};
}
},
};
18 changes: 9 additions & 9 deletions eslint/rules/jquery-no-delegate-undelegate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ module.exports = {
description: 'Disallow the use of the deprecated $.delegate and $.undelegate',
category: 'jQuery deprecated functions',
recommended: true,
url: 'https://api.jquery.com/delegate/'
url: 'https://api.jquery.com/delegate/',
},
schema: [],
messages: {
delegate: 'jQuery $.delegate and $.undelegate are deprecated, use $.on and $.off instead'
}
delegate: 'jQuery $.delegate and $.undelegate are deprecated, use $.on and $.off instead',
},
},

/**
Expand All @@ -22,7 +22,7 @@ module.exports = {
create: function (context) {
'use strict';

var utils = require('./utils.js');
const utils = require('./utils.js');

return {
/**
Expand All @@ -31,17 +31,17 @@ module.exports = {
* @param {Object} node - The node to check.
*/
CallExpression: function (node) {
if (node.callee.type !== 'MemberExpression') {return;}
if (node.callee.type !== 'MemberExpression') { return; }

if (!['delegate', 'undelegate'].includes(node.callee.property.name)) {return;}
if (!['delegate', 'undelegate'].includes(node.callee.property.name)) { return; }

if (utils.isjQuery(node)) {
context.report({
node: node,
messageId: 'delegate'
messageId: 'delegate',
});
}
}
},
};
}
},
};
14 changes: 7 additions & 7 deletions eslint/rules/jquery-no-deprecated-expr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ module.exports = {
description: 'Disallow the use of deprecated way to add to custom selectors',
category: 'jQuery deprecated functions',
recommended: true,
url: 'https://api.jquery.com/load/'
url: 'https://api.jquery.com/load/',
},
schema: []
schema: [],
},

/**
Expand All @@ -19,7 +19,7 @@ module.exports = {
create: function (context) {
'use strict';

var utils = require('./utils.js');
const utils = require('./utils.js');

return {
/**
Expand All @@ -31,7 +31,7 @@ module.exports = {
if (utils.isjQuery(node)) {
context.report({
node: node,
message: 'jQuery.expr[":"] is deprecated; Use jQuery.expr.pseudos instead'
message: 'jQuery.expr[":"] is deprecated; Use jQuery.expr.pseudos instead',
});
}
},
Expand All @@ -45,10 +45,10 @@ module.exports = {
if (utils.isjQuery(node)) {
context.report({
node: node,
message: 'jQuery.expr.filters is deprecated; Use jQuery.expr.pseudos instead'
message: 'jQuery.expr.filters is deprecated; Use jQuery.expr.pseudos instead',
});
}
}
},
};
}
},
};
Loading
Loading