Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify price event provider event data formation. #474

Open
bricht opened this issue Dec 18, 2020 · 8 comments
Open

Unify price event provider event data formation. #474

bricht opened this issue Dec 18, 2020 · 8 comments

Comments

@bricht
Copy link
Contributor

bricht commented Dec 18, 2020

The price event data providers contain some duplicate code. Specifically buildEventData functions in FullReindex and PartialReindex providers.
For example
\Magento\CatalogPriceDataExporter\Model\Provider\FullReindex\CustomOptionPriceEvent::buildEventData
and
\Magento\CatalogPriceDataExporter\Model\Provider\PartialReindex\CustomOptionPriceEvent::buildEventData
are the same.

We need to bring this logic out of the providers in order to avoid code duplication.

Related to #465

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2020

Hi @bricht. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@mslabko
Copy link
Member

mslabko commented Dec 18, 2020

@magento export issue to Jira project SFAPP as Story

@magento-engcom-team
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-197) is successfully created for this issue.

@RakeshJesadiya
Copy link

@mslabko @bricht Which repo contains the Class CustomOptionPriceEvent.php defined in the issue?
Thank you.

@bricht
Copy link
Contributor Author

bricht commented Dec 21, 2020

@mslabko @bricht Which repo contains the Class CustomOptionPriceEvent.php defined in the issue?
Thank you.

https://github.com/magento/commerce-data-export/pull/21/files#diff-ba1939c8004a571b5cb8c76346ab6b6a96427eb9ae468b637174954c486a83f8

@RakeshJesadiya
Copy link

When the CatalogPriceDataExporter module will be merged? FYI @bricht

@RakeshJesadiya
Copy link

@magento I am working on this

@RakeshJesadiya
Copy link

@mslabko @bricht Please check the PR, magento/commerce-data-export#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants