-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify price event provider event data formation. #474
Comments
Hi @bricht. Thank you for your report. Please, add a comment to assign the issue:
|
@magento export issue to Jira project SFAPP as Story |
✅ Jira issue (https://jira.corp.magento.com/browse/SFAPP-197) is successfully created for this issue. |
When the CatalogPriceDataExporter module will be merged? FYI @bricht |
@magento I am working on this |
@mslabko @bricht Please check the PR, magento/commerce-data-export#23 |
The price event data providers contain some duplicate code. Specifically buildEventData functions in FullReindex and PartialReindex providers.
For example
\Magento\CatalogPriceDataExporter\Model\Provider\FullReindex\CustomOptionPriceEvent::buildEventData
and
\Magento\CatalogPriceDataExporter\Model\Provider\PartialReindex\CustomOptionPriceEvent::buildEventData
are the same.
We need to bring this logic out of the providers in order to avoid code duplication.
Related to #465
The text was updated successfully, but these errors were encountered: