Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tag 2.1.2 missing #1871

Open
Vinai opened this issue Jul 15, 2022 · 3 comments
Open

Release tag 2.1.2 missing #1871

Vinai opened this issue Jul 15, 2022 · 3 comments

Comments

@Vinai
Copy link

Vinai commented Jul 15, 2022

Preconditions (*)

  1. The package magento/product-community-edition 2.4.3 requires "magento/adobe-stock-integration": "2.1.2"
  2. This repository https://github.com/magento/adobe-stock-integration/ does not contain a tag 2.1.2, only 2.1.2-p1
  3. This repository does have a branch 2.1.2, but branches are not supposed to be used as a target dependency in a release, since they do not point to a specific commit.

Expected result (*)

  1. That it is possible to resolve the dependencies of magento/product-community-edition manually by visiting the source repositories and selecting the tagged release version

Actual result (*)

  1. The dependency on magento/adobe-stock-integration version 2.1.2 can not be accurately resolved manually.
@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2022

Hi @Vinai. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@Vinai
Copy link
Author

Vinai commented Jul 15, 2022

Suggested solution:

  1. rename the 2.1.2 branch to 2.1.2-develop or something, so the 2.1.2 ref does not conflict with the tag
  2. check out to the commit that was used to build the 2.1.2 release package (possibly that is the 2.1.2 branch?), create a tag 2.1.2, and push the tag

@danslo
Copy link

danslo commented Aug 16, 2022

@sidolov Could you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants