Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphaned attributes #12

Open
peterjaap opened this issue Mar 31, 2022 · 0 comments
Open

Remove orphaned attributes #12

peterjaap opened this issue Mar 31, 2022 · 0 comments

Comments

@peterjaap
Copy link
Contributor

  • Create a list of all product attributes from the database
  • Search through the codebase to see whether they are mentioned in InstallData/UpdateData scripts - those are fine
  • Search through phtml files to see whether they are used (also make sure to look for getAttributeName / setAttributeName instead of just attribute_name) - those are fine
  • We should whitelist all core attributes since those have names that occur a lot ('name' / 'sku')
  • The remaining product attributes might be removeable

This probably can't be done automatically since it'll most likely show too many false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant