Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Duplicate code #6

Open
vadimjustus opened this issue Mar 2, 2019 · 0 comments
Open

Refactoring: Duplicate code #6

vadimjustus opened this issue Mar 2, 2019 · 0 comments
Labels
selected Selected for next minor version

Comments

@vadimjustus
Copy link
Collaborator

Current Problem
Following the current programming standards of Magento (see https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html), causes some duplicate code. E.g. the class \Firegento\ContentProvisioning\Model\Command\ApplyPageEntry is pretty similar to \Firegento\ContentProvisioning\Model\Command\ApplyBlockEntry.

TODO
An solution must be found, how to bring in the required functionality and following the technical guidelines.
@vadimjustus vadimjustus added the selected Selected for next minor version label Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
selected Selected for next minor version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vadimjustus