Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm IDs are discarded too soon #36

Open
ronkorving opened this issue May 18, 2016 · 0 comments
Open

Confirm IDs are discarded too soon #36

ronkorving opened this issue May 18, 2016 · 0 comments

Comments

@ronkorving
Copy link
Member

This line is problematic:

The server will keep sending those messages until confirmation has been successfully completed. I fear that the loop and its conditions around line 203 will prevent those confirm IDs from ever re-entering the confirmation list.

The behavior would be better if it replicated the JS version which only clears the confirm IDs list on a 2xx response: https://github.com/mage/message-stream.js/blob/e62d35156526204a88369d08a16a336dfff73774/http.js#L49

cc @AlmirKadric @nullorvoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant