Skip to content

Commit

Permalink
fix docker utility: only try to update image start with magda-. Pre…
Browse files Browse the repository at this point in the history
…viously, it matches `magda-io/xxxx` (where should only match `magda-io/magda-xxxx`) incorrectly
  • Loading branch information
t83714 committed Oct 8, 2023
1 parent e3ff2cb commit 3d684eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- #3485: New feature for registry records manager: able to search record by keywords & added records list view
- Display organizational unit ID info in the user general info panel
- #3100: Conenctor SDK: Allow runtime filter code to be supply to connectors via Helm config
- Fixed an issue with docker build utiliy

## v2.3.1

Expand Down
2 changes: 1 addition & 1 deletion scripts/create-docker-context-for-node-component.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ function updateDockerFile(sourceDir, destDir) {
const replacedDockerFileContents = dockerFileContents
// Add a repository if this is a magda image
.replace(
/FROM .*(magda-[^:\s]+)(:[^\s]+)/,
/FROM .*(magda-[^:\s\/]+)(:[^\s]+)/,
"FROM " + repository + "$1" + (tags[0] ? ":" + tags[0] : "$2")
);

Expand Down

0 comments on commit 3d684eb

Please sign in to comment.