Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark __init__ to return None #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark __init__ to return None #174

wants to merge 1 commit into from

Conversation

SpyrosRoum
Copy link

Closes #173

@SpyrosRoum
Mark __init__ to return None
de822b8 
This is needed accordign to [PEP 484](https://peps.python.org/pep-0484/)
@ldthorne
Copy link

thanks so much for the fix here @SpyrosRoum! @madzak anything i can do to help get this merged and released?

louis-jaris
louis-jaris approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@louis-jaris louis-jaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to follow PEP standards/best practices.

@dolfinus
Copy link

I see 2 approvals here, does anything stop this PR from being merged?

@SpyrosRoum
Copy link
Author

I see 2 approvals here, does anything stop this PR from being merged?

@madzak Needs to approve and merge it since they have write access to the repo. Considering the last commit was 10 months ago, it's probably safe to say they don't spend much time on this project anymore..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jaris louis-jaris louis-jaris approved these changes

@Dimitrioglo Dimitrioglo Dimitrioglo approved these changes

@tdg5 tdg5 tdg5 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark JsonFormatter's __init__ to return None
6 participants
@SpyrosRoum @ldthorne @dolfinus @tdg5 @Dimitrioglo @louis-jaris