Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong factor in check_cpufreq for -G #137

Closed
ggzengel opened this issue Jan 23, 2024 · 1 comment · Fixed by #138
Closed

wrong factor in check_cpufreq for -G #137

ggzengel opened this issue Jan 23, 2024 · 1 comment · Fixed by #138
Assignees
@madrisan
Labels
bug good first issue

Comments

@ggzengel
Copy link

https://github.com/madrisan/nagios-plugins-linux/blob/2ea02e2173a4307a051a7ae97c7867da7e6ac70a/plugins/check_cpufreq.c#L135C25-L135C31

case 'G': factor = 1.0/100000; break;

this should be 1.0/10^6 and not 1.0/10^5

root:/usr/lib/nagios/plugins# ./check_cpufreq -M
cpufreq (Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz) OK | cpu0_freq=2722;;;1200;3100 <snip>
root:/usr/lib/nagios/plugins# ./check_cpufreq -G
cpufreq (Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz) OK | cpu0_freq=28;;;12;31 <snip>
@madrisan madrisan self-assigned this Jan 25, 2024
@madrisan madrisan linked a pull request Jan 25, 2024 that will close this issue
fix(check_cpufreq): wrong factor in check_cpufreq for -G #138
Merged
@madrisan
Copy link
Owner

Good catch! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madrisan madrisan

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(check_cpufreq): wrong factor in check_cpufreq for -G madrisan/nagios-plugins-linux
2 participants
@madrisan @ggzengel