Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outsource inference #293

Open
johannbrehmer opened this issue Mar 15, 2019 · 1 comment
Open

Outsource inference #293

johannbrehmer opened this issue Mar 15, 2019 · 1 comment
Assignees
@johannbrehmer
Labels
enhancement New feature or request internal Refactoring without interface or functionality changes

Comments

@johannbrehmer
Copy link
Collaborator

Rewrite madminer.limits to wrap around pyhf. That will not only do all the histogram stuff (e.g. for SALLY) for us, but also takes care of the profiling / p-value calculation / CLs stuff. I discussed this with Lukas Heinrich and it should be possible to use pyhf's inference part using a RASCAL-style likelihood ratio estimator.
@johannbrehmer johannbrehmer added high priority Should be fixed as soon as possible internal Refactoring without interface or functionality changes labels Mar 15, 2019
@johannbrehmer johannbrehmer added this to the v0.3.0 milestone Mar 15, 2019
@johannbrehmer johannbrehmer self-assigned this Mar 15, 2019
@johannbrehmer johannbrehmer removed this from the v0.3.0 milestone Apr 5, 2019
@johannbrehmer johannbrehmer changed the title Inference with pyhf Inference with external tools Jun 28, 2019
@johannbrehmer johannbrehmer changed the title Inference with external tools Outsource inference Jun 28, 2019
@johannbrehmer johannbrehmer added the enhancement New feature or request label Oct 30, 2019
@kratsg
Copy link

kratsg commented Mar 4, 2020

./cc @matthewfeickert

@johannbrehmer johannbrehmer removed the high priority Should be fixed as soon as possible label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johannbrehmer johannbrehmer

Labels
enhancement New feature or request internal Refactoring without interface or functionality changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratsg @johannbrehmer