Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing add button on text blocks #510

Open
morpheus-87 opened this issue Sep 1, 2016 · 6 comments
Open

Missing add button on text blocks #510

morpheus-87 opened this issue Sep 1, 2016 · 6 comments

Comments

@morpheus-87
Copy link
Contributor

When I add a new text block, it is not possible to add more blocks - neither above nor underneath.

@raffij
Copy link
Contributor

raffij commented Sep 1, 2016

I'll take a look

@morpheus-87
Copy link
Contributor Author

Did you already take a look on this topic?

@raffij
Copy link
Contributor

raffij commented Sep 19, 2016

I took a look and I think what you are seeing is the desired behaviour for now.

.st--hide-top-controls .st-top-controls .st-block-addition {
  display: none;
}

When we started on the redesign we tried to get rid of as much clutter as possible. So you are seeing the mode which could be described as "Get typing and then add extra content".

https://github.com/madebymany/sir-trevor-js/blob/master/src/editor.js#L161-L178

@SgtOddball
Copy link
Contributor

Whilst removing clutter is a noble cause, it is confusing from a UX standpoint as the hover isn't an obvious (also the '+' at the bottom isn't a high enough contrast, seriously, I missed it was there at first) interaction method since there's nothing to infer that hovering will cause something to happen.

@morpheus-87
Copy link
Contributor Author

morpheus-87 commented Sep 19, 2016

Thank you for that information, @raffij!

My intention was the following: when I start with a blank editor and create a new text block, there is no chance to add any extra content - neither above nor underneath the new text block. You just pointed at the addition button at the top, for what I found a way to "reintroduce" it for the text block. Where is decided, if the button underneath is displayed?

Thanks also for your comment, @SgtOddball, which hits also my experience it's not very obvious, how to add new content between two blocks.

@raffij
Copy link
Contributor

raffij commented Sep 19, 2016

Thanks for your feedback both of you.

What you see currently is a way of getting something in place for our current working practices and then finding out how others want to use it and work towards a different solution or adding different functionality in through configuration changes.

@morpheus-87 something like this will do what you want.

.st-block:last-child .st-block-addition {
  display: block;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants