From f76809d8fc2ed771c8b29e34cc72213d07ae34b9 Mon Sep 17 00:00:00 2001
From: roschro-fau <robert.schroeter@fau.de>
Date: Wed, 1 May 2024 09:02:59 +0200
Subject: [PATCH] added required tag to columns and rows input and added both
 inputs to validity check for QR Code form

---
 .../components/preparation/QrCodeForm.svelte  | 21 ++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/lib/components/preparation/QrCodeForm.svelte b/src/lib/components/preparation/QrCodeForm.svelte
index 76653ee..8965991 100644
--- a/src/lib/components/preparation/QrCodeForm.svelte
+++ b/src/lib/components/preparation/QrCodeForm.svelte
@@ -61,7 +61,7 @@
 	}
 
 	function isValid() {
-		let idList = ["mail"];
+		let idList = ["mail", "columns", "rows"];
 		if (uniformSalivaDistances) {
 			idList = [...idList, "distances"];
 		} else {
@@ -248,11 +248,26 @@
 				<div class="flex">
 					<label class="label w-1/6">
 						<span>Number of columns</span>
-						<input class="input" type="number" min="1" max="5" bind:value={$qrCodeProps.numColumns} />
+						<input
+							bind:value={$qrCodeProps.numColumns}
+							id="columns"
+							class="input"
+							type="number"
+							min="1" max="5"
+							required
+						/>
 					</label>
 					<label class="label w-1/6 mx-6">
 						<span>Number of rows</span>
-						<input class="input" type="number" min="1" max="{$qrCodeProps.includeParticipantId ? 5 : $qrCodeProps.useLetterFormat ? 6 : 7}" bind:value={$qrCodeProps.numRows} />
+						<input
+							bind:value={$qrCodeProps.numRows}
+							id="rows"
+							class="input"
+							type="number"
+							min="1"
+							max="{$qrCodeProps.includeParticipantId ? 5 : $qrCodeProps.useLetterFormat ? 6 : 7}"
+							required
+						/>
 					</label>
 				</div>
 			{/if}