Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get ddm task from sbibm library #4

Open
rakaar opened this issue Jun 24, 2024 · 2 comments
Open

Unable to get ddm task from sbibm library #4

rakaar opened this issue Jun 24, 2024 · 2 comments

Comments

@rakaar
Copy link

rakaar commented Jun 24, 2024

In notebooks/Paper-Figure-2-likelihood-comparison.ipynb. There is a line task = sbibm.get_task("ddm") using the latest version of sbibm v1.1.0. With two_mooons as param, it works.

Screenshot from 2024-06-24 21-18-30

There is no ddm task in the sbibm tasks folder - https://github.com/sbi-benchmark/sbibm/tree/main/sbibm/tasks

@janfb
Copy link
Collaborator

janfb commented Jun 25, 2024

I think the reason is that you are using the recent PyPI installation of sbibm.

If you install the requirements of this repository from requirements.txt as described in the readme, then it will install sbibm from the ddm-task branch, which does contain the "ddm" task.

sbibm @ git+https://github.com/mackelab/sbibm@ddm-task#egg=sbibm

Does this help?

@rakaar
Copy link
Author

rakaar commented Jun 25, 2024

I think the reason is that you are using the recent PyPI installation of sbibm.

If you install the requirements of this repository from requirements.txt as described in the readme, then it will install sbibm from the ddm-task branch, which does contain the "ddm" task.

sbibm @ git+https://github.com/mackelab/sbibm@ddm-task#egg=sbibm

Does this help?

yes, it worked. Thank you for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants