Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEmpty() doesn't support numeric model values #110

Open
avaragado opened this issue Oct 27, 2015 · 1 comment · May be fixed by #129
Open

isEmpty() doesn't support numeric model values #110

avaragado opened this issue Oct 27, 2015 · 1 comment · May be fixed by #129

Comments

@avaragado
Copy link

I have a selectize component with the required attribute set. This means isEmpty is called on validation to check whether the model has a value or not.

If the model value is numeric (eg set programmatically rather than by user selection), the isEmpty test fails as numbers don't have a length property.
@PhiLhoSoft PhiLhoSoft mentioned this issue Mar 2, 2016
Open
@PhiLhoSoft
Copy link
Contributor

Yes, at long least, the lazy !val.length should be val.length === 0...

PhiLhoSoft added a commit to PhiLhoSoft/angular-selectize that referenced this issue Mar 3, 2016
@PhiLhoSoft
Treat user entered options differently from original options
daa7dd0 
Or programmatically changed options.
Fixes issue machineboy2045#69.
Also fixes machineboy2045#110...

Demo at http://plnkr.co/edit/2352rt
@PhiLhoSoft PhiLhoSoft linked a pull request Mar 3, 2016 that will close this issue
Open
arturgspb pushed a commit to rwmeta/angular-selectize that referenced this issue Mar 31, 2016
[~] Fix bug with required validation error with default value (machin…
7abb518 
…eboy2045#110, machineboy2045#116, machineboy2045#121)
@arturgspb arturgspb mentioned this issue Mar 31, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat user entered options differently from original options PhiLhoSoft/angular-selectize
2 participants
@avaragado @PhiLhoSoft