New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra single quote not needed #1

Open

fjgarlin opened this issue May 4, 2018 · 1 comment

fjgarlin commented May 4, 2018

Not 100% sure if this is intentional as I couldn't run the code locally yet (time!) but I saw this

gdpr_dump/src/ExpressionHelper.php

Line 56 in 49045cc

$sqlValue = (is_int($value) || is_float($value)) ? (string) $value : "'$value";

and thought it could be a typo.

Author

fjgarlin commented May 4, 2018

PR for this if it's an actual typo: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment